Skip to content

Change "Types/modules" title of search tab to be more accurate - #45898

Merged
bors merged 2 commits into
rust-lang:masterfrom
JRegimbal:master
Dec 6, 2017
Merged

Change "Types/modules" title of search tab to be more accurate#45898
bors merged 2 commits into
rust-lang:masterfrom
JRegimbal:master

Conversation

@JRegimbal

@JRegimbalJRegimbal commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

From issue #45787. Used "In name" as per suggestion from @Seeker14491.

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2017
@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 12, 2017
@GuillaumeGomez

GuillaumeGomez commented Nov 12, 2017

Copy link
Copy Markdown
Member

Please remove the second commit (the merge one).

Also, I don't like much the new name. Maybe others like it or have propositions?

@JRegimbal

JRegimbal commented Nov 12, 2017

Copy link
Copy Markdown
ContributorAuthor

Sorry about the merge I'm new to this. I removed it. The search is done by name, so maybe "By name" would be better? Is there a way to get a consensus on the new name?

@alexcrichton

alexcrichton commented Nov 12, 2017

Copy link
Copy Markdown
Member

r? @steveklabnik

@Seeker14491

Seeker14491 commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

"By name" sounds good to me too.

@GuillaumeGomez

GuillaumeGomez commented Nov 12, 2017

Copy link
Copy Markdown
Member

@JRegimbal: It'll be debated if needed in the next docs meeting. If most like the name, then it'll get merged otherwise you'll be asked to update the name.

@JRegimbal

JRegimbal commented Nov 12, 2017

Copy link
Copy Markdown
ContributorAuthor

Ah okay!

@bors

bors commented Nov 13, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #45673) made this pull request unmergeable. Please resolve the merge conflicts.

@JRegimbal
"Types/modules" in tab to "In name"
42ae3dc
"Types/modules" doesn't properly describe the results since it includes
other things whose name matches the search term.
@shepmastershepmaster added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2017
@shepmaster

shepmaster commented Dec 1, 2017

Copy link
Copy Markdown
Member

Triage ping @rust-lang/docs and @steveklabnik — we haven't heard from y'all in over two weeks; would someone mind giving an update?

@steveklabnik

steveklabnik commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

We didn't talk about it yet, we will next weds for sure.

@QuietMisdreavus

QuietMisdreavus commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

We talked about this in today's docs team meeting, and decided to take the opportunity to tweak the naming in all the tabs, not just the main one. We settled on using "In Names", "In Parameters", and "In Return Types", in order. Can you change the tab names to those, instead?

@QuietMisdreavusQuietMisdreavus added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed I-nominated labels Dec 5, 2017
@JRegimbal
Changed tab names to those agreed upon.
41df62c
Tabs are "In Names", "In Parameters", and "In Return Types".
@QuietMisdreavus

QuietMisdreavus commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

Excellent! Thanks so much!

@bors r+ rollup

@bors

bors commented Dec 5, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 41df62c has been approved by QuietMisdreavus

@bors

bors commented Dec 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 41df62c with merge d10b04d...

bors added a commit that referenced this pull request Dec 6, 2017
@bors
Auto merge of#45898- JRegimbal:master, r=QuietMisdreavus
d10b04d
Change "Types/modules" title of search tab to be more accurate
From issue #45787. Used "In name" as per suggestion from @Seeker14491.
@bors

bors commented Dec 6, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing d10b04d to master...

@bors
bors merged commit 41df62c into rust-lang:masterDec 6, 2017
@QuietMisdreavusQuietMisdreavus mentioned this pull request Dec 12, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@JRegimbal@GuillaumeGomez@alexcrichton@Seeker14491@bors@shepmaster@steveklabnik@QuietMisdreavus@kennytm