Skip to content

Refactor Option::filter method - #45933

Merged
bors merged 1 commit into
rust-lang:masterfrom
shanavas786:refactor-filter
Nov 13, 2017
Merged

Refactor Option::filter method#45933
bors merged 1 commit into
rust-lang:masterfrom
shanavas786:refactor-filter

Conversation

@shanavas786

@shanavas786shanavas786 commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2017
sinkuu
sinkuu reviewed Nov 11, 2017
View reviewed changes
Comment threadsrc/libcore/option.rs Outdated

@sinkuusinkuuNov 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: ; is unnecessary here.

@shanavas786shanavas786Nov 11, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Updated. Thanks

@alexcrichton

alexcrichton commented Nov 12, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Nov 12, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit abff092 has been approved by alexcrichton

@alexcrichtonalexcrichton self-assigned this Nov 12, 2017
@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 13, 2017
@kennytm
Rollup merge ofrust-lang#45933- shanavas786:refactor-filter, r=alex…
3604737
…crichton
Refactor Option::filter method
@kennytmkennytm mentioned this pull request Nov 13, 2017
Merged
bors added a commit that referenced this pull request Nov 13, 2017
@bors
Auto merge of#45956- kennytm:rollup, r=kennytm
e312c8a
Rollup of 9 pull requests
- Successful merges: #45828, #45892, #45893, #45914, #45917, #45927, #45933, #45952, #45954
- Failed merges:
@bors
bors merged commit abff092 into rust-lang:masterNov 13, 2017
@LukasKalbertodt

LukasKalbertodt commented Nov 15, 2017

Copy link
Copy Markdown
Contributor

What was the reason for this change? I don't really care that my code was changed, I just don't really understand why. I guess it's because it has fewer lines and only one None? Was this change discussed in IRC? I would really appreciate it, if PRs for such changes would have at least a short description. Otherwise the rest of the world has no clue what's going on.

@bstrie

bstrie commented Nov 15, 2017

Copy link
Copy Markdown
Contributor

@LukasKalbertodt I surmise it was just mildly more idiomatic to use if let to reduce the slight amount of repetition.

@Kerollmops

Kerollmops commented Nov 15, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Why not this so ?

matchself{Some(x)ifpredicate(&x) => Some(x),
_ => None}

@sinkuu

sinkuu commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

@Kerollmops That would be cetainly better, but currently impossible (produces an error E0008).

@Kerollmops

Kerollmops commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

Ho ! you're right ! sorry ! I hope the NLL will change this kind of error.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sinkuusinkuusinkuu left review comments
@sugar700sugar700sugar700 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@shanavas786@alexcrichton@bors@LukasKalbertodt@bstrie@Kerollmops@sinkuu@sugar700@kennytm