Skip to content

update match-expressions.rs with DepNode labels - #45941

Merged
bors merged 3 commits into
rust-lang:masterfrom
gaurikholkar-zz:master
Nov 14, 2017
Merged

update match-expressions.rs with DepNode labels#45941
bors merged 3 commits into
rust-lang:masterfrom
gaurikholkar-zz:master

Conversation

@gaurikholkar-zz

@gaurikholkar-zzgaurikholkar-zz commented Nov 12, 2017

Copy link
Copy Markdown

As a part of #44924, I have updated the match-expressions.rs. The PR has tests verified for the following dependency nodes for let-expressions

  • MirValidated
  • MirOptimized
  • TypeCheckTables
  • TypeOfItem
  • GenericsOfItem
  • PredicatesOfItem
  • FnSignature

cc @michaelwoerister
r? @nikomatsakis

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2017
@michaelwoerister

michaelwoerister commented Nov 13, 2017

Copy link
Copy Markdown
Member

Thanks a lot, @gaurikholkar! Looks good to me. Could you please make the except=s line up with the cfgs in the lines above them? Or, if that conflicts with tidy, indent them by 4 spaces.

@gaurikholkar-zz

gaurikholkar-zz commented Nov 13, 2017•
edited
Loading

Copy link
Copy Markdown
Author

@michaelwoerister done

@nikomatsakis

nikomatsakis commented Nov 13, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 13, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 39f468e has been approved by nikomatsakis

@michaelwoerister

michaelwoerister commented Nov 13, 2017

Copy link
Copy Markdown
Member

Thanks @gaurikholkar!

@michaelwoerister

michaelwoerister commented Nov 13, 2017

Copy link
Copy Markdown
Member

@bors rollup

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 14, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#45941- gaurikholkar:master, r=nikomatsakis
189bdfc
update match-expressions.rs with DepNode labels
As a part of rust-lang#44924, I have updated the match-expressions.rs. The PR has tests verified for the following dependency nodes for let-expressions
- MirValidated
- MirOptimized
- TypeCheckTables
- TypeOfItem
- GenericsOfItem
- PredicatesOfItem
- FnSignature
cc @michaelwoerister
r? @nikomatsakis
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 14, 2017
Merged
bors added a commit that referenced this pull request Nov 14, 2017
@bors
Auto merge of#45981- GuillaumeGomez:rollup, r=GuillaumeGomez
2711f21
Rollup of 7 pull requests
- Successful merges: #45815, #45941, #45950, #45951, #45961, #45967, #45970
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 14, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#45941- gaurikholkar:master, r=nikomatsakis
c95ef0d
update match-expressions.rs with DepNode labels
As a part of rust-lang#44924, I have updated the match-expressions.rs. The PR has tests verified for the following dependency nodes for let-expressions
- MirValidated
- MirOptimized
- TypeCheckTables
- TypeOfItem
- GenericsOfItem
- PredicatesOfItem
- FnSignature
cc @michaelwoerister
r? @nikomatsakis
bors added a commit that referenced this pull request Nov 14, 2017
@bors
Auto merge of#45981- GuillaumeGomez:rollup, r=GuillaumeGomez
dbeb5bf
Rollup of 7 pull requests
- Successful merges: #45815, #45941, #45950, #45961, #45967, #45970, #45977
- Failed merges:
@bors
bors merged commit 39f468e into rust-lang:masterNov 14, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gaurikholkar-zz@michaelwoerister@nikomatsakis@bors@kennytm@gaurikholkar