Skip to content

fix some python3 incompatibilities - #46044

Merged
bors merged 1 commit into
rust-lang:masterfrom
collinanderson:py3
Nov 18, 2017
Merged

fix some python3 incompatibilities#46044
bors merged 1 commit into
rust-lang:masterfrom
collinanderson:py3

Conversation

@collinanderson

@collinandersoncollinanderson commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

No description provided.

kennytm
kennytm approved these changes Nov 16, 2017
View reviewed changes

@kennytmkennytm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.

Comment threadsrc/libstd_unicode/unicode.py Outdated

@kennytmkennytmNov 16, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe refactor this to?

ifany(lo<=char<=hiforlo, hiincomp_exclusions):
continue

Comment threadsrc/libstd_unicode/unicode.py Outdated

@kennytmkennytmNov 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we ever get non-integer from the source code? All the int() calls could be dropped in not.

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2017
@collinanderson

collinanderson commented Nov 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Hah. Good points. Fixed both.

@kennytm

kennytm commented Nov 16, 2017

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Nov 16, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 261d4d8 has been approved by kennytm

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 18, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#46044- collinanderson:py3, r=kennytm
c36228f
fix some python3 incompatibilities
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 18, 2017
Merged
bors added a commit that referenced this pull request Nov 18, 2017
@bors
Auto merge of#46073- GuillaumeGomez:rollup, r=GuillaumeGomez
18250b0
Rollup of 4 pull requests
- Successful merges: #45767, #46044, #46066, #46071
- Failed merges:
@bors
bors merged commit 261d4d8 into rust-lang:masterNov 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytmkennytmkennytm approved these changes

Assignees

No one assigned

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@collinanderson@kennytm@bors