Uh oh!
There was an error while loading. Please reload this page.
typeck aggregate rvalues in MIR type checker - #46054
Merged
Merged
Conversation
arielb1
reviewed
Nov 19, 2017
| reported_errors: FxHashSet<(Ty<'tcx>, Span)>, | ||
| constraints: MirTypeckRegionConstraints<'tcx>, | ||
| // FIXME(#45940) - True if this is a MIR shim or ADT constructor |
Contributor
There was a problem hiding this comment.
Isn't it a better idea to instead normalize field types in ADT constructors?
nikomatsakis
commented
Nov 20, 2017
ContributorAuthor
@arielb1 see latest commit. Tests seem to pass still. |
arielb1
commented
Nov 20, 2017
Contributor
r=me with adt constructors being normalized in rustc_mir::shim instead of in type_check |
arielb1
commented
Nov 20, 2017
Contributor
@bors r+ |
bors
commented
Nov 20, 2017
Collaborator
📌 Commit a59147c has been approved by |
nikomatsakisforce-pushed
the
nll-master-to-rust-master-1
branch
from
November 22, 2017 09:34
a59147c to
c52e51dComparenikomatsakis
commented
Nov 22, 2017
ContributorAuthor
@bors r=arielb1 (rebased) |
bors
commented
Nov 22, 2017
Collaborator
📌 Commit c52e51d has been approved by |
bors
commented
Nov 23, 2017
Collaborator
bors added a commit
that referenced
this pull request
Nov 23, 2017
…ielb1 typeck aggregate rvalues in MIR type checker This branch is an attempt to land content by @spastorino and @Nashenas88 that was initially landed on nll-master while we waited for #45825 to land. The biggest change it contains is that it extends the MIR type-checker to also type-check MIR aggregate rvalues (at least partially). Specifically, it checks that the operands provided for each field have the right type. It does not yet check that their well-formedness predicates are met. That is #45827. It also does not check other kinds of rvalues (that is #45959). @spastorino is working on those issues now. r? @arielb1
bors
commented
Nov 23, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is an attempt to land content by @spastorino and @Nashenas88 that was initially landed on nll-master while we waited for #45825 to land.
The biggest change it contains is that it extends the MIR type-checker to also type-check MIR aggregate rvalues (at least partially). Specifically, it checks that the operands provided for each field have the right type.
It does not yet check that their well-formedness predicates are met. That is #45827. It also does not check other kinds of rvalues (that is #45959). @spastorino is working on those issues now.
r? @arielb1