Skip to content

Print the address of the pointed value in Pointer impl for Rc and Arc - #46121

Merged
bors merged 1 commit into
rust-lang:masterfrom
malbarbo:rc_arc_pointer
Nov 21, 2017
Merged

Print the address of the pointed value in Pointer impl for Rc and Arc#46121
bors merged 1 commit into
rust-lang:masterfrom
malbarbo:rc_arc_pointer

Conversation

@malbarbo

Copy link
Copy Markdown
Contributor

Fixes#35384

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm

Copy link
Copy Markdown
Member

r? @dtolnay

@rust-highfiverust-highfive assigned dtolnay and unassigned kennytmNov 20, 2017
@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2017
@kennytm

Copy link
Copy Markdown
Member
BTW, build failure:
[00:03:22] error[E0277]: the trait bound `T: core::fmt::Pointer` is not satisfied
[00:03:22] --> /checkout/src/liballoc/arc.rs:1331:9
[00:03:22] |
[00:03:22] 1331 | fmt::Pointer::fmt(&**self, f)
[00:03:22] | ^^^^^^^^^^^^^^^^^ the trait `core::fmt::Pointer` is not implemented for `T`
[00:03:22] |
[00:03:22] = help: consider adding a `where T: core::fmt::Pointer` bound
[00:03:22] = note: required by `core::fmt::Pointer::fmt`
[00:03:22] [00:03:22] error[E0277]: the trait bound `T: core::fmt::Pointer` is not satisfied
[00:03:22] --> /checkout/src/liballoc/rc.rs:1075:9
[00:03:22] |
[00:03:22] 1075 | fmt::Pointer::fmt(&**self, f)
[00:03:22] | ^^^^^^^^^^^^^^^^^ the trait `core::fmt::Pointer` is not implemented for `T`
[00:03:22] |
[00:03:22] = help: consider adding a `where T: core::fmt::Pointer` bound
[00:03:22] = note: required by `core::fmt::Pointer::fmt`
[00:03:22] [00:03:23] error: aborting due to 2 previous errors
[00:03:23] [00:03:23] error: Could not compile `alloc`.

@dtolnay

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 20, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit cbcaf73 has been approved by dtolnay

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 20, 2017
Print the address of the pointed value in Pointer impl for Rc and Arc
Fixesrust-lang#35384
@kennytmkennytm mentioned this pull request Nov 20, 2017
bors added a commit that referenced this pull request Nov 20, 2017
Rollup of 9 pull requests
- Successful merges: #46082, #46088, #46092, #46107, #46119, #46121, #46122, #46124, #46128
- Failed merges:
@bors
bors merged commit cbcaf73 into rust-lang:masterNov 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@malbarbo@rust-highfive@kennytm@dtolnay@bors