Skip to content

Fix a typo in ToSocketAddrs documentation - #46141

Merged
bors merged 1 commit into
rust-lang:masterfrom
aqrln:tosocketaddrs-doc-fix-typo
Nov 21, 2017
Merged

Fix a typo in ToSocketAddrs documentation#46141
bors merged 1 commit into
rust-lang:masterfrom
aqrln:tosocketaddrs-doc-fix-typo

Conversation

@aqrln

@aqrlnaqrln commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

Fix a typo in ToSocketAddrs documentation: s/ToSocketsAddr/ToSocketAddrs

@aqrln
Fix a typo in ToSocketAddrs documentation
0789a1d
Fix a typo in ToSocketAddrs documentation: s/ToSocketsAddr/ToSocketAddrs
@rust-highfive

rust-highfive commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

KodrAus
KodrAus approved these changes Nov 21, 2017
View reviewed changes

@KodrAusKodrAus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aqrln! This looks good to me.

@KodrAus

KodrAus commented Nov 21, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 21, 2017

Copy link
Copy Markdown
Collaborator

@KodrAus: 🔑 Insufficient privileges: Not in reviewers

@KodrAus

KodrAus commented Nov 21, 2017

Copy link
Copy Markdown
Contributor

:(

@KodrAus

KodrAus commented Nov 21, 2017

Copy link
Copy Markdown
Contributor

r? @frewsxcv

@frewsxcv

frewsxcv commented Nov 21, 2017

Copy link
Copy Markdown
Contributor

thanks!

@bors r+ rollup

@bors

bors commented Nov 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0789a1d has been approved by frewsxcv

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 21, 2017
@kennytmkennytm mentioned this pull request Nov 21, 2017
Merged
@kennytmkennytm mentioned this pull request Nov 21, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Nov 21, 2017
@kennytm
Rollup merge ofrust-lang#46141- aqrln:tosocketaddrs-doc-fix-typo, r…
5b54193
…=frewsxcv
Fix a typo in ToSocketAddrs documentation
Fix a typo in `ToSocketAddrs` documentation: s/ToSocketsAddr/ToSocketAddrs
@kennytmkennytm mentioned this pull request Nov 21, 2017
Merged
bors added a commit that referenced this pull request Nov 21, 2017
@bors
Auto merge of#46166- kennytm:rollup, r=kennytm
63739ab
Rollup of 11 pull requests
- Successful merges: #45987, #46031, #46050, #46052, #46103, #46120, #46134, #46141, #46148, #46155, #46157
- Failed merges:
@bors
bors merged commit 0789a1d into rust-lang:masterNov 21, 2017
@aqrln
aqrln deleted the tosocketaddrs-doc-fix-typo branch November 22, 2017 07:59
@aqrln

aqrln commented Nov 22, 2017

Copy link
Copy Markdown
ContributorAuthor

Thanks! Happy to have my first contribution to Rust and hope this isn't the last one :)

@aqrln

aqrln commented Jan 8, 2018

Copy link
Copy Markdown
ContributorAuthor

Hi! Today I noticed that the typo is still there at https://doc.rust-lang.org/std/net/trait.ToSocketAddrs.html. AFAICT the patch has never made it into any release. I'm not aware of the exact release process and policies but heads up if it should have.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KodrAusKodrAusKodrAus approved these changes

Assignees

@KodrAusKodrAus

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aqrln@rust-highfive@KodrAus@bors@frewsxcv@kennytm