Uh oh!
There was an error while loading. Please reload this page.
incr.comp.: Some preparatory work for caching more query results. - #46299
Merged
Conversation
bors
commented
Nov 27, 2017
Collaborator
☔ The latest upstream changes (presumably #44884) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
approved these changes
Nov 27, 2017
nikomatsakis
commented
Nov 27, 2017
Contributor
r=me after rebase |
michaelwoeristerforce-pushed
the
incr-comp-krimskrams
branch
from
November 28, 2017 12:09
2a2783b to
3bb25d6Comparemichaelwoerister
commented
Nov 28, 2017
MemberAuthor
@bors r=nikomatsakis |
bors
commented
Nov 28, 2017
Collaborator
📌 Commit 3bb25d6 has been approved by |
bors
commented
Nov 29, 2017
Collaborator
⌛ Testing commit 3bb25d6 with merge 1d1431789b75ee49dd1c3f506d409ce0b071efa2... |
bors
commented
Nov 29, 2017
Collaborator
💔 Test failed - status-travis |
michaelwoerister
commented
Nov 29, 2017
MemberAuthor
Looks spurious. |
michaelwoerister
commented
Nov 30, 2017
MemberAuthor
@bors p=1 (A while back we decided that incr. comp. PRs get higher priority until the end of the year. Since there are 4 incr. comp. PRs open in parallel at the moment, with more to come, I'm taking advantage of this now) |
bors
commented
Nov 30, 2017
Collaborator
bors added a commit
that referenced
this pull request
Nov 30, 2017
…atsakis incr.comp.: Some preparatory work for caching more query results. This PR * adds and updates some encoding/decoding routines for various query result types so they can be cached later, and * adds missing `[input]` annotations for a few `DepNode` variants. The situation around having to explicitly mark dep-nodes/queries as inputs is not really satisfactory. I hope we can find a way of making this more fool-proof in the future. r? @nikomatsakis
bors
commented
Nov 30, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This was referenced Nov 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
[input]annotations for a fewDepNodevariants.The situation around having to explicitly mark dep-nodes/queries as inputs is not really satisfactory. I hope we can find a way of making this more fool-proof in the future.
r? @nikomatsakis