Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #46399
Closed
arielb1 wants to merge 24 commits into
Closed
Conversation
When the only difference between the two types in a type error is that one is a reference to the other type (`T` vs `&T`) or both are references differing only in their mutability (`&T` vs `&mut T`), don't highlight the type (`T`).
...that were removed in 77c3bfa.
The documentation states: "The name output should be the name of the library." and this is already done in more recently-added callers.
…ans for type definitions.
* Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
The usage of `Path::new` prevented out-of-tree builds (like the bots do) from working by accident! Closesrust-lang#46195
We want librustdoc to pickup the env_logger dependency from the sysroot. This ensures that the same copy of env_logger is used for both internal crates (e.g. librustc_driver, libsyntax) and librustdoc Closesrust-lang#46383
This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
arielb1
commented
Nov 30, 2017
ContributorAuthor
@bors r+ p=11 |
rust-highfive
commented
Nov 30, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Nov 30, 2017
Collaborator
📌 Commit db4339f has been approved by |
bors
commented
Nov 30, 2017
Collaborator
⌛ Testing commit db4339f0f0835462f1a4aeee15a807a3dec3f517 with merge 8223d4bbc41bbd43f8d8bd282eff4455769068bb... |
bors
commented
Nov 30, 2017
Collaborator
💔 Test failed - status-travis |
Member
Well the error is legit, I guess one of estebank's suggestion PR is conflicting with some other changes in this rollup (or maybe those PRs are not up-to-date with the latest master, causing false Travis ✅.) |
added 5 commits
November 30, 2017 18:02
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
rustc_llvm: remove stale references ...that were removed in 77c3bfa. r? @alexcrichton
…s, r=nagisa Update compiler-builtins and use it in the 128-bit lowering MIR test This picks up the lang item implementations from rust-lang/compiler-builtins#210 cc rust-lang#45676@est31@nagisa
Fix hygiene bug. Fixesrust-lang#42708. r? @nrc
On type mismatch error highlight `&` when type matches When the only difference between the two types in a type error is that one is a reference to the other type (`T` vs `&T`) or both are references differing only in their mutability (`&T` vs `&mut T`), don't highlight the type (`T`).
added 2 commits
November 30, 2017 18:02
…uginfo-spans, r=eddyb incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. r? @nikomatsakis
…etMisdreavus rustdoc: Fix issues with cross-crate inlined associated items * Visibility was missing from impl items. * Attributes and docs were missing from consts and types in impls. * Const default values were missing from traits. This unifies the code that handles associated items from impls and traits.
added 3 commits
November 30, 2017 18:02
…-Simulacrum rustbuild: Fix a typo with the Cargo book The usage of `Path::new` prevented out-of-tree builds (like the bots do) from working by accident! Closesrust-lang#46195
…imulacrum Remove librustdoc dependency on env_logger We want librustdoc to pickup the env_logger dependency from the sysroot. This ensures that the same copy of env_logger is used for both internal crates (e.g. librustc_driver, libsyntax) and librustdoc Closesrust-lang#46383
…r=eddyb incr.comp.: Make traits::VTable encodable and decodable. Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point. r? @eddyb
ContributorAuthor
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!in unreachable code a hard error #45880, Use suggestions instead of notes ref mismatches #46256, rustc_llvm: remove stale references #46280, Update compiler-builtins and use it in the 128-bit lowering MIR test #46290, Fix hygiene bug. #46343, On type mismatch error highlight&when type matches #46349, incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. #46368, incr.comp.: Remove ability to produce incr. comp. hashes during metadata export. #46370, rustdoc: Fix issues with cross-crate inlined associated items #46384, rustbuild: Fix a typo with the Cargo book #46385, Remove librustdoc dependency on env_logger #46386