Uh oh!
There was an error while loading. Please reload this page.
Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0. - #46411
Merged
Conversation
rust-highfive
commented
Nov 30, 2017
Contributor
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
rillian
commented
Nov 30, 2017
ContributorAuthor
cc @LukasKalbertodt. This fixes an apparent oversight in #46411. |
ollie27
commented
Nov 30, 2017
Contributor
They're not in 1.22.0 either. 1.23.0 is the first version with these methods. Also, I assume you meant to link to #44042. |
rillian
commented
Nov 30, 2017
ContributorAuthor
Oops, yes, that's correct. Thanks! |
rillianforce-pushed
the
str_ascii
branch
2 times, most recently
from
November 30, 2017 20:35
2949f54 to
6fdbf4bComparerillian
commented
Dec 1, 2017
ContributorAuthor
The documentation is also incorrect in 1.23.0 beta. Could someone please nominate this issue for inclusion there? |
bors
commented
Dec 2, 2017
Collaborator
☔ The latest upstream changes (presumably #46288) made this pull request unmergeable. Please resolve the merge conflicts. |
The ascii_methods_on_intrinsics feature stabilization didn't land in time for 1.21.0. Update the annotation so the documentation is correct about when these methods became available.
rillian
commented
Dec 5, 2017
ContributorAuthor
@Kimundi review ping? |
rillian
commented
Dec 8, 2017
ContributorAuthor
kennytm
commented
Dec 11, 2017
Member
@bors r+ rollup |
bors
commented
Dec 11, 2017
Collaborator
📌 Commit 6aef5e3 has been approved by |
bors
commented
Dec 12, 2017
Collaborator
bors added a commit
that referenced
this pull request
Dec 12, 2017
Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0. The ascii_methods_on_intrinsics feature stabilization didn't land in time for 1.21.0. Update the annotation so the documentation is correct about when these methods became available.
rillian
commented
Dec 12, 2017
ContributorAuthor
Thanks @kennytm! :D |
bors
commented
Dec 12, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
commented
Jan 10, 2018
Member
Looks like we forgot to backport this to 1.23.0 (sorry about that!) so removing the beta tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ascii_methods_on_intrinsics feature stabilization
didn't land in time for 1.21.0. Update the annotation
so the documentation is correct about when these
methods became available.