Skip to content

MIR: change "lvalue" terminology to "place". - #46425

Merged
bors merged 2 commits into
rust-lang:masterfrom
eddyb:mir-place
Dec 1, 2017
Merged

MIR: change "lvalue" terminology to "place".#46425
bors merged 2 commits into
rust-lang:masterfrom
eddyb:mir-place

Conversation

@eddyb

@eddybeddyb commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

As pointed out elsewhere, "lvalue" vs "rvalue" is a misleading/obscure distinction and several other choices have been proposed, the one I prefer being "place" vs "value".

This PR only touches the "lvalue" side, and only in MIR-related code, as it's already a lot and could rot.

@rust-highfive

rust-highfive commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis

nikomatsakis commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

@bors r+ p=1

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0f7e416 has been approved by nikomatsakis

@nikomatsakis

nikomatsakis commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

Giving high priority because bitrot probability is high.

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 1, 2017
@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #46236) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb

eddyb commented Dec 1, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 473f044 has been approved by nikomatsakis

@kennytm

kennytm commented Dec 1, 2017

Copy link
Copy Markdown
Member

@bors r=15

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 473f044 has been approved by 15

@kennytm

kennytm commented Dec 1, 2017

Copy link
Copy Markdown
Member

oops sorry

@bors r=nikomatsakis p=15

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 473f044 has been approved by nikomatsakis

@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 473f044 with merge bb42071...

bors added a commit that referenced this pull request Dec 1, 2017
@bors
Auto merge of#46425- eddyb:mir-place, r=nikomatsakis
bb42071
MIR: change "lvalue" terminology to "place".
As pointed out elsewhere, "lvalue" vs "rvalue" is a misleading/obscure distinction and several other choices have been proposed, the one I prefer being "place" vs "value".
This PR only touches the "lvalue" side, and only in MIR-related code, as it's already a lot and could rot.
@bors

bors commented Dec 1, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing bb42071 to master...

@borsbors mentioned this pull request Dec 1, 2017
Closed
@bors
bors merged commit 473f044 into rust-lang:masterDec 1, 2017
This was referenced Dec 1, 2017
Merged
Merged
Merged
@eddyb
eddyb deleted the mir-place branch December 1, 2017 22:03
@eddybeddyb mentioned this pull request Jan 29, 2018
Merged
bors added a commit that referenced this pull request Jan 29, 2018
@bors
Auto merge of#47837- eddyb:going-places, r=nikomatsakis
90eb44a
Replace "lvalue" terminology with "place".
See #46425 for the previous PR (which only changed MIR-related code).
r? @nikomatsakis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eddyb@rust-highfive@nikomatsakis@bors@kennytm