Uh oh!
There was an error while loading. Please reload this page.
rustc: don't unpack newtypes of scalar-pairs with mismatched alignment. - #46428
Merged
Conversation
rust-highfive
commented
Dec 1, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
eddybforce-pushed
the
scalar-pair-unpacking
branch
from
December 1, 2017 17:56
632afcd to
081d733Compareeddyb
commented
Dec 1, 2017
ContributorAuthor
r? @nikomatsakis or @arielb1 |
eddybforce-pushed
the
scalar-pair-unpacking
branch
from
December 1, 2017 22:31
081d733 to
d455955Comparearielb1
commented
Dec 3, 2017
Contributor
@bors r+ |
bors
commented
Dec 3, 2017
Collaborator
📌 Commit d455955 has been approved by |
bors
commented
Dec 3, 2017
Collaborator
bors added a commit
that referenced
this pull request
Dec 3, 2017
rustc: don't unpack newtypes of scalar-pairs with mismatched alignment. This PR fixes a potential problem where a packed newtype of a pair was also considered a pair, even though it didn't have the required alignment of the pair. cc @oli-obk It's possible miri hit something like this, with an unstable feature, but it's more general.
bors
commented
Dec 3, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential problem where a packed newtype of a pair was also considered a pair, even though it didn't have the required alignment of the pair.
cc @oli-obk It's possible miri hit something like this, with an unstable feature, but it's more general.