Skip to content

Update old link - #46495

Merged
bors merged 1 commit into
rust-lang:masterfrom
timotree3:patch-1
Dec 6, 2017
Merged

Update old link#46495
bors merged 1 commit into
rust-lang:masterfrom
timotree3:patch-1

Conversation

@timotree3

@timotree3timotree3 commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

The CONTRIBUTING.md page currently links to an old wiki page in rust-lang/rust-wiki-backup. There is a more up-to-date page in-tree so I changed the link to point there so new contributors can find it more easily.

@timotree3
Update old link
38ef723
This page currently links to an old wiki page in rust-lang/rust-wiki-backup. There is a more up-to-date page in-tree so I changed the link to point there so new contributors can find it more easily.
@rust-highfive

rust-highfive commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@QuietMisdreavus

QuietMisdreavus commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

Note for posterity: The wiki page in question has been migrated to the forge, but it's effectively unchanged, and still references old things like make check.

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2017
@nikomatsakis

nikomatsakis commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 38ef723 has been approved by nikomatsakis

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 6, 2017
@frewsxcv
Rollup merge ofrust-lang#46495- timotree3:patch-1, r=nikomatsakis
17dd988
Update old link
The CONTRIBUTING.md page currently links to an old wiki page in rust-lang/rust-wiki-backup. There is a more up-to-date page in-tree so I changed the link to point there so new contributors can find it more easily.
@frewsxcvfrewsxcv mentioned this pull request Dec 6, 2017
Merged
bors added a commit that referenced this pull request Dec 6, 2017
@bors
Auto merge of#46538- frewsxcv:rollup, r=frewsxcv
833785b
Rollup of 7 pull requests
- Successful merges: #46136, #46378, #46431, #46483, #46495, #46502, #46512
- Failed merges:
@bors
bors merged commit 38ef723 into rust-lang:masterDec 6, 2017
@timotree3
timotree3 deleted the patch-1 branch July 6, 2021 23:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@timotree3@rust-highfive@QuietMisdreavus@nikomatsakis@bors@kennytm