Uh oh!
There was an error while loading. Please reload this page.
Resolve absolute paths as extern under a feature flag - #46613
Merged
Conversation
ContributorAuthor
There was a problem hiding this comment.
The part about single-segment imports (use my_crate;/use crate;) works, but it is kinda hacked into.
Solving it properly requires larger refactoring that would also solve a number of pre-existing problems (#29036 and similar).
nikomatsakis
approved these changes
Dec 11, 2017
Contributor
There was a problem hiding this comment.
Nit: isn't there some helper function we can use here for this test against keywords::CrateRoot.name()?
ContributorAuthor
There was a problem hiding this comment.
There's no such existing function.
(Also there are too many "crate roots" with different properties now, it's better to be explicit.)
Contributor
There was a problem hiding this comment.
Nit: as above, helper function?
nikomatsakis
commented
Dec 11, 2017
Contributor
@bors r+ |
bors
commented
Dec 11, 2017
Collaborator
📌 Commit 675581a has been approved by |
bors
commented
Dec 12, 2017
Collaborator
⌛ Testing commit 675581a290571ea38141b1f6e202bf66d444122a with merge 4ae1d40e143c9a1a3722d1b921255c4b4e2bdc74... |
bors
commented
Dec 12, 2017
Collaborator
💔 Test failed - status-travis |
kennytm
commented
Dec 12, 2017
Member
The new gate test failed on Details |
kennytm
reviewed
Dec 12, 2017
petrochenkov
commented
Dec 12, 2017
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Dec 12, 2017
Collaborator
📌 Commit b07e26e has been approved by |
bors
commented
Dec 13, 2017
Collaborator
bors added a commit
that referenced
this pull request
Dec 13, 2017
Resolve absolute paths as extern under a feature flag cc #44660 r? @nikomatsakis
bors
commented
Dec 13, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
bors added a commit
that referenced
this pull request
Jan 7, 2018
Support `extern` in paths Implement the primary alternative to #46613 + #45771, achieving the same effect without requiring changes to other imports. Both need to be experimentally evaluated before making further progress. The PR also adds docs for all these related features into the unstable book. cc #44660 r? @nikomatsakis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #44660
r? @nikomatsakis