Uh oh!
There was an error while loading. Please reload this page.
Update Cargo and its dependencies - #46630
Conversation
rust-highfive
commented
Dec 10, 2017
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Dec 11, 2017
@bors r+ |
bors
commented
Dec 11, 2017
📌 Commit e21b4f6 has been approved by |
bors
commented
Dec 11, 2017
Update Cargo and its dependencies Just a routine update!
bors
commented
Dec 11, 2017
💔 Test failed - status-travis |
kennytm
commented
Dec 11, 2017
A test in cargo failed, looks legit. |
e21b4f6 to
955c8e7Comparealexcrichton
commented
Dec 13, 2017
@bors: r=nikomatsakis |
bors
commented
Dec 13, 2017
📌 Commit 955c8e7 has been approved by |
bors
commented
Dec 13, 2017
⌛ Testing commit 955c8e7332ebe8c9ca8fa124fd2f19fcbe8b79ba with merge 015ce4e103205a9c537cbd435d1c13fff0179d0b... |
bors
commented
Dec 13, 2017
💔 Test failed - status-travis |
kennytm
commented
Dec 13, 2017
This has broken several RLS tests (cc @nrc)? Not sure if legit. |
alexcrichton
commented
Dec 15, 2017
@bors: r+ prays it's spurious |
bors
commented
Dec 15, 2017
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Dec 15, 2017
📌 Commit 955c8e7 has been approved by |
alexcrichton
commented
Dec 15, 2017
@bors: retry |
nrc
commented
Dec 15, 2017
This doesn't look spurious to me. I updated Cargo locally and get the same failures in the RLS. The pattern of failure is what happens when no compilation happens. Probably something changed in the Cargo API which is screwing up the RLS, but nothing in Cargo's commit log looks suspicious. |
bors
commented
Dec 15, 2017
🔒 Merge conflict |
alexcrichton
commented
Dec 15, 2017
@nrc can you help me debug this? I spent a few hours yesterday tracing through rls tests and the rls iteslf (I found the output quite difficult to debug) and I even reverted Cargo back to the original revision and still got the same error. The few commits landing in Cargo have what I would presume as minor changes. There's some minor tweaks but I can't make heads or tails of anything in the rls logs and/or internals as to what's actually changing or where the error is coming from. |
bors
commented
Dec 15, 2017
☔ The latest upstream changes (presumably #46740) made this pull request unmergeable. Please resolve the merge conflicts. |
nrc
commented
Dec 18, 2017
Yep, looking into it now. |
bors
commented
Dec 23, 2017
📌 Commit 6bdc986 has been approved by |
bors
commented
Dec 23, 2017
⌛ Testing commit 6bdc9865b9a99b0764b9148b8d207c022ce6b0c7 with merge 5f1d1fdc9f6ea3b7c8d3fe7dc17b52afac731b75... |
bors
commented
Dec 23, 2017
💔 Test failed - status-travis |
alexcrichton
commented
Dec 24, 2017
Ok I've debugged this to something unrelated (the debugging stuff I added to the test didn't help). It's an issue with using the bundled libcurl, still investigating... |
6bdc986 to
61eca72Comparealexcrichton
commented
Dec 24, 2017
@bors: r=nikomatsakis |
bors
commented
Dec 24, 2017
📌 Commit 61eca72 has been approved by |
bors
commented
Dec 24, 2017
🔒 Merge conflict |
Just a routine update!
61eca72 to
325d739Comparealexcrichton
commented
Dec 24, 2017
@bors: r=nikomatsakis |
bors
commented
Dec 24, 2017
📌 Commit 325d739 has been approved by |
bors
commented
Dec 24, 2017
Update Cargo and its dependencies Just a routine update!
bors
commented
Dec 24, 2017
☀️ Test successful - status-appveyor, status-travis |
Just a routine update!