Skip to content

Reject superfluous :: in IPv6 addresses - #46671

Merged
bors merged 1 commit into
rust-lang:masterfrom
varkor:contrib-2
Dec 20, 2017
Merged

Reject superfluous :: in IPv6 addresses#46671
bors merged 1 commit into
rust-lang:masterfrom
varkor:contrib-2

Conversation

@varkor

@varkorvarkor commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

Fixes#46263.

@rust-highfive

rust-highfive commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label Dec 12, 2017
@KodrAus

KodrAus commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

Thanks @varkor!

This looks good to me. With this change we'll start rejecting previously accepted (but technically invalid) Ipv6Addrs where the address specifies 0 groups of 0s.

@rfcbot fcp merge

@kennytm

kennytm commented Dec 12, 2017

Copy link
Copy Markdown
Member

@KodrAus Only members of the team can awake rfcbot 😄

cc @rust-lang/libs

@sfackler

sfackler commented Dec 12, 2017

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Dec 12, 2017•
edited by BurntSushi
Loading

Copy link
Copy Markdown

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 12, 2017
@rfcbot

rfcbot commented Dec 19, 2017

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 19, 2017
@alexcrichton

alexcrichton commented Dec 19, 2017

Copy link
Copy Markdown
Member

@bors: r=KodrAus

@bors

bors commented Dec 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit bd1cf04 has been approved by KodrAus

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels Dec 20, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017
@kennytm
Rollup merge ofrust-lang#46671- varkor:contrib-2, r=KodrAus
76e2cc5
Reject superfluous `::` in IPv6 addresses
Fixesrust-lang#46263.
@kennytmkennytm mentioned this pull request Dec 20, 2017
Merged
bors added a commit that referenced this pull request Dec 20, 2017
@bors
Auto merge of#46874- kennytm:rollup, r=kennytm
81622c6
Rollup of 14 pull requests
- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors
bors merged commit bd1cf04 into rust-lang:masterDec 20, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KodrAusKodrAus

Labels

final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@varkor@rust-highfive@KodrAus@kennytm@sfackler@rfcbot@alexcrichton@bors@frewsxcv