Skip to content

Fix return value of LLVMRustMetadataAsValue - #46691

Merged
bors merged 1 commit into
rust-lang:masterfrom
varkor:contrib-3
Dec 12, 2017
Merged

Fix return value of LLVMRustMetadataAsValue#46691
bors merged 1 commit into
rust-lang:masterfrom
varkor:contrib-3

Conversation

@varkor

@varkorvarkor commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

LLVMRustMetadataAsValue would previously return void, despite the
corresponding Rust function expecting to return a ValueRef.

@varkor
Fix return value of LLVMRustMetadataAsValue
6487ee3
`LLVMRustMetadataAsValue` would previously return `void`, despite the
corresponding Rust function expecting to return a `ValueRef`.
@rust-highfive

rust-highfive commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@hanna-kruppe

hanna-kruppe commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

This kind of bug is a real pain. Thanks for finding it!

@bors r+

@bors

bors commented Dec 12, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 6487ee3 has been approved by rkruppe

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 12, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 12, 2017
@kennytm
Rollup merge ofrust-lang#46691- varkor:contrib-3, r=rkruppe
37cc63a
Fix return value of `LLVMRustMetadataAsValue`
`LLVMRustMetadataAsValue` would previously return `void`, despite the
corresponding Rust function expecting to return a `ValueRef`.
@kennytmkennytm mentioned this pull request Dec 12, 2017
Merged
bors added a commit that referenced this pull request Dec 12, 2017
@bors
Auto merge of#46696- kennytm:rollup, r=kennytm
6a36019
Rollup of 4 pull requests
- Successful merges: #46668, #46672, #46691, #46694
- Failed merges:
@bors
bors merged commit 6487ee3 into rust-lang:masterDec 12, 2017
@varkor
varkor deleted the contrib-3 branch December 12, 2017 23:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@varkor@rust-highfive@hanna-kruppe@bors@kennytm@nikomatsakis