Uh oh!
There was an error while loading. Please reload this page.
rustc: Set release mode cgus to 16 by default - #46910
Merged
Merged
Conversation
rust-highfive
commented
Dec 21, 2017
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Dec 21, 2017
MemberAuthor
michaelwoerister
commented
Dec 21, 2017
Member
@bors r+ Let's try it. We can easily revert before the next release if there's a major problem. |
bors
commented
Dec 21, 2017
Collaborator
📌 Commit 24834eb has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
…haelwoerister rustc: Set release mode cgus to 16 by default This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closesrust-lang#45320
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
…haelwoerister rustc: Set release mode cgus to 16 by default This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closesrust-lang#45320
alexcrichton
commented
Dec 23, 2017
MemberAuthor
alexcrichtonforce-pushed
the
thinlto-default
branch
from
December 23, 2017 22:05
3230850 to
8e25bf3Comparealexcrichton
commented
Dec 23, 2017
MemberAuthor
I've opened an LLVM bug for that failure. |
alexcrichtonforce-pushed
the
thinlto-default
branch
from
December 23, 2017 22:38
8e25bf3 to
93e5facCompareThis commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closesrust-lang#45320
alexcrichtonforce-pushed
the
thinlto-default
branch
from
December 24, 2017 00:04
93e5fac to
b5361d0Comparealexcrichton
commented
Dec 24, 2017
MemberAuthor
@bors: r=michaelwoerister |
bors
commented
Dec 24, 2017
Collaborator
📌 Commit b5361d0 has been approved by |
bors
commented
Dec 25, 2017
Collaborator
bors added a commit
that referenced
this pull request
Dec 25, 2017
rustc: Set release mode cgus to 16 by default This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closes#45320
bors
commented
Dec 25, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Probably because of this I am seeing nearly halved compilation times. (But I am seeing a problem I'll file soon, I don't know if it's the same LLVM failure reported above. Edit: it's #47015 ). |
Merged
This was referenced Jan 11, 2018
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.
Closes#45320