Uh oh!
There was an error while loading. Please reload this page.
Bounce out the layout refactor from beta - #46925
Merged
Merged
Conversation
rust-highfive
commented
Dec 21, 2017
Contributor
|
arielb1force-pushed
the
make-the-trains-run-on-time
branch
from
December 21, 2017 20:31
80280f1 to
2eaec8bComparearielb1
commented
Dec 21, 2017
ContributorAuthor
I thought that @alexcrichton's PR #45905 conflicts with #45225, but it is not based on @eddyb's PR and landed in parallel with it, so it's probably a better idea to leave it in. |
eddyb
commented
Dec 21, 2017
Contributor
r=me |
This should make sure that they stay fixed.
arielb1force-pushed
the
make-the-trains-run-on-time
branch
from
December 21, 2017 22:23
2eaec8b to
d6a5946Comparearielb1
commented
Dec 21, 2017
ContributorAuthor
This is a big beta change @bors r+ p=10 |
bors
commented
Dec 21, 2017
Collaborator
📌 Commit d6a5946 has been approved by |
bors
commented
Dec 22, 2017
Collaborator
bors added a commit
that referenced
this pull request
Dec 22, 2017
Bounce out the layout refactor from beta @eddyb's #45225 was supposed to get into get into 1.24, but due to an ordering mistake, it had snuck into 1.23. That wide-effect translation-changing PR had poked LLVM's weak corners and caused many regressions (3 of them have fixes I include here, but also #46897, #46845, #46449, #46371). I don't think it is a good idea to land it in the beta (1.23) because there are bound to be some regressions we didn't patch. Therefore, I am reverting it in time for stable, along with its related regression fixes. r? @michaelwoerister (I think)
bors
commented
Dec 22, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
michaelwoerister
commented
Dec 27, 2017
Member
Thanks, folks! |
This was referenced Dec 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eddyb's #45225 was supposed to get into get into 1.24, but due to an ordering mistake, it had snuck into 1.23.
That wide-effect translation-changing PR had poked LLVM's weak corners and caused many regressions (3 of them have fixes I include here, but also #46897, #46845, #46449, #46371). I don't think it is a good idea to land it in the beta (1.23) because there are bound to be some regressions we didn't patch.
Therefore, I am reverting it in time for stable, along with its related regression fixes.
r? @michaelwoerister (I think)