Uh oh!
There was an error while loading. Please reload this page.
Update clippy - #46937
Closed
Manishearth wants to merge 1 commit into
Closed
Conversation
rust-highfive
commented
Dec 22, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
commented
Dec 22, 2017
MemberAuthor
r? @oli-obk |
oli-obk
commented
Dec 22, 2017
Contributor
You need to run x.py to update the Cargo.lock |
Manishearth
commented
Dec 22, 2017
MemberAuthor
pushed |
kennytm
commented
Dec 22, 2017
Member
@bors r+ |
bors
commented
Dec 22, 2017
Collaborator
📌 Commit 5935f1f has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
Update clippy Unbreaks it rust-lang/rust-clippy#2289
bors
commented
Dec 25, 2017
Collaborator
🔒 Merge conflict |
kennytm
commented
Jan 2, 2018
Member
@Manishearth Would you mind reviving this (rebase on rust master + update clippy to latest master)? Clippy (and miri as well) needs to be test-pass before branching off to the next beta. |
oli-obk
commented
Jan 2, 2018
Contributor
Clippy and miri aren't distributed, why is the beta blocked on them passing? |
kennytm
commented
Jan 2, 2018
Member
@oli-obk it is tested in the same manner as RLS and rustfmt. Anyway, this is unblocked on 1.24-beta by not testing them. |
kennytm
commented
Jan 4, 2018
Member
Superseded by #47172. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks it
rust-lang/rust-clippy#2289