') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [MIR Borrowck] Moveck inline asm statements by matthewjasper · Pull Request #46975 · rust-lang/rust · GitHub
Skip to content

[MIR Borrowck] Moveck inline asm statements - #46975

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:mir-moveck-asm
Dec 26, 2017
Merged

[MIR Borrowck] Moveck inline asm statements#46975
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:mir-moveck-asm

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Dec 23, 2017

Copy link
Copy Markdown
Contributor

Closes#45695

New behavior:

@rust-highfive

rust-highfive commented Dec 23, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matthewjaspermatthewjasper changed the title Moveck inline asm statements[MIR Borrowck] Moveck inline asm statementsDec 23, 2017
@matthewjasper

matthewjasper commented Dec 23, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @arielb1

arielb1
arielb1 reviewed Dec 23, 2017
View reviewed changes
Comment threadsrc/test/run-pass/asm-in-moved.rs Outdated

@arielb1arielb1Dec 23, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most tests use this instead:

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

see e.g. the asm-out-assign test

@arielb1

arielb1 commented Dec 23, 2017

Copy link
Copy Markdown
Contributor

r=me with tests fixed to use

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

@matthewjasper

matthewjasper commented Dec 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Done. The compile-fail test still uses ignore, as cfg isn't understood by the test-runner.

@arielb1

arielb1 commented Dec 24, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 1a308ba has been approved by arielb1

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a308ba with merge 70836ed585280838f37f6da818f73c83f1576327...

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@estebank

estebank commented Dec 25, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a308ba with merge 1f4a500b62c71bd87c5571a8ce3b76b91657f23e...

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented Dec 25, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@bors retry #47002

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a308ba with merge d1bfe337f9ceced97d45f71f2f37efbe7b2c7b8a...

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@estebank

estebank commented Dec 26, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a308ba with merge cddc4a6...

bors added a commit that referenced this pull request Dec 26, 2017
@bors
Auto merge of#46975- matthewjasper:mir-moveck-asm, r=arielb1
cddc4a6
[MIR Borrowck] Moveck inline asm statements
Closes#45695
New behavior:
* Input operands to `asm!` are moved, direct output operands are initialized.
* Direct, non-read-write outputs match the assignment changes in #46752 (Shallow writes, end borrows).
@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing cddc4a6 to master...

@bors
bors merged commit 1a308ba into rust-lang:masterDec 26, 2017
@matthewjasper
matthewjasper deleted the mir-moveck-asm branch September 3, 2018 21:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@arielb1arielb1arielb1 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@arielb1arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewjasper@rust-highfive@arielb1@bors@estebank@kennytm