Skip to content

Follow up to #46924, fix massive spurious failure when starting docker - #47000

Merged
bors merged 1 commit into
rust-lang:masterfrom
kennytm:follow-up-46924
Dec 26, 2017
Merged

Follow up to #46924, fix massive spurious failure when starting docker#47000
bors merged 1 commit into
rust-lang:masterfrom
kennytm:follow-up-46924

Conversation

@kennytm

@kennytmkennytm commented Dec 25, 2017•
edited by arielb1
Loading

Copy link
Copy Markdown
Member

It seems using fe80::/64 causes docker start to fail with "Address already in use". Try to change to a unique local address range instead.

fe80::/64 is a link-local address (similar to 169.254.0.0/16 in IPv4). Let's try to use a random "private network" address to see whether that fixes things.

cc #47002

r? @aidanhs

@kennytm
Follow up torust-lang#46924
472a3c1
It seems using `fe80::/64` causes `docker start` to fail with "Address
already in use". Try to change to a unique local address range instead.
@kennytmkennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 25, 2017
@kennytm

kennytm commented Dec 25, 2017

Copy link
Copy Markdown
MemberAuthor

@bors try

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 472a3c1 with merge 5ddec7adfa1883fd5f1db3984809cefb6cc2932b...

@kennytm

kennytm commented Dec 25, 2017

Copy link
Copy Markdown
MemberAuthor

@bors r- try- retry

@kennytmkennytm changed the title [WIP] Follow up to #46924Follow up to #46924, fix massive spurious failure when starting dockerDec 25, 2017
@kennytm

kennytm commented Dec 25, 2017

Copy link
Copy Markdown
MemberAuthor

The docker has successfully been built on the try branch. Now I'm trying to check if it works on the auto branch. To check this, I'll r+ for confirmation, and then r- it after 20 minutes.

@bors r+

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 472a3c1 has been approved by kennytm

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 472a3c1 with merge a555a3f87cad81e0aef4f08f9096bc3601c29e26...

@kennytm

kennytm commented Dec 25, 2017

Copy link
Copy Markdown
MemberAuthor

@bors r- retry

@kennytmkennytm mentioned this pull request Dec 25, 2017
Closed
@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 25, 2017
@arielb1

arielb1 commented Dec 25, 2017

Copy link
Copy Markdown
Contributor

@bors r+ p=10

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 472a3c1 has been approved by arielb1

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 472a3c1 with merge 7674ffb...

bors added a commit that referenced this pull request Dec 25, 2017
@bors
Auto merge of#47000- kennytm:follow-up-46924, r=arielb1
7674ffb
Follow up to #46924, fix massive spurious failure when starting docker
It seems using `fe80::/64` causes `docker start` to fail with "Address already in use". Try to change to a unique local address range instead.
`fe80::/64` is a link-local address (similar to `169.254.0.0/16` in IPv4). Let's try to use a random "private network" address to see whether that fixes things.
cc #47002
r? @aidanhs
@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@kennytm

kennytm commented Dec 26, 2017

Copy link
Copy Markdown
MemberAuthor

@bors retry

3 hour timeout.

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 472a3c1 with merge d21e176607e046614b1f2e661a0a98c8139ce87f...

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented Dec 26, 2017

Copy link
Copy Markdown
MemberAuthor

@bors retry

sccache segfault?!

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 472a3c1 with merge 2e83f3c...

bors added a commit that referenced this pull request Dec 26, 2017
@bors
Auto merge of#47000- kennytm:follow-up-46924, r=arielb1
2e83f3c
Follow up to #46924, fix massive spurious failure when starting docker
It seems using `fe80::/64` causes `docker start` to fail with "Address already in use". Try to change to a unique local address range instead.
`fe80::/64` is a link-local address (similar to `169.254.0.0/16` in IPv4). Let's try to use a random "private network" address to see whether that fixes things.
cc #47002
r? @aidanhs
@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing 2e83f3c to master...

@bors
bors merged commit 472a3c1 into rust-lang:masterDec 26, 2017
@kennytm
kennytm deleted the follow-up-46924 branch December 26, 2017 08:32
@aidanhsaidanhs mentioned this pull request Dec 27, 2017
Open
@aidanhs

aidanhs commented Dec 27, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Reported sccache segfault, though I don't know if it was sccache's fault or if it was 'just' some failure cascading (mozilla/sccache#210)

@glandium

glandium commented Dec 27, 2017

Copy link
Copy Markdown
Contributor

FWIW, we've had the lookForDIEsToKeep llvm-dsymutil crashes on Firefox. See https://bugzilla.mozilla.org/show_bug.cgi?id=1381043 and https://bugs.llvm.org/show_bug.cgi?id=33873 . It's fixed in llvm upstream, but the root cause in rustc probably still exists (it was obviously a llvm bug that it led to a crash, but the root cause was that rustc produces bad DWARF data).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aidanhsaidanhs

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kennytm@bors@arielb1@aidanhs@glandium