Uh oh!
There was an error while loading. Please reload this page.
Use the right TLS model for CloudABI. - #47110
Conversation
CloudABI doesn't do dynamic linking. For this reason, there is no need to handle any other TLS model than local-exec. CloudABI's C library doesn't provide a __tls_get_addr() function to do Dynamic TLS. By forcing local-exec to be used here, we ensure that we don't generate function calls to __tls_get_addr().
rust-highfive
commented
Jan 1, 2018
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
commented
Jan 3, 2018
I'm not familiar with TLS, but from what I searched, the |
EdSchouten
commented
Jan 3, 2018
Thanks for the review! It looks like The main difference between With |
kennytm
commented
Jan 3, 2018
Thanks for explanation! Could you summarize those (#47110 (comment) + #47110 (comment)) as a code-comment? r=me after that. |
Sure thing! r= @kennytm |
kennytm
commented
Jan 3, 2018
@bors r+ rollup |
bors
commented
Jan 3, 2018
📌 Commit 05949b0 has been approved by |
Use the right TLS model for CloudABI. CloudABI doesn't do dynamic linking. For this reason, there is no need to handle any other TLS model than local-exec. CloudABI's C library doesn't provide a __tls_get_addr() function to do Dynamic TLS. By forcing local-exec to be used here, we ensure that we don't generate function calls to __tls_get_addr().
Use the right TLS model for CloudABI. CloudABI doesn't do dynamic linking. For this reason, there is no need to handle any other TLS model than local-exec. CloudABI's C library doesn't provide a __tls_get_addr() function to do Dynamic TLS. By forcing local-exec to be used here, we ensure that we don't generate function calls to __tls_get_addr().
Use the right TLS model for CloudABI. CloudABI doesn't do dynamic linking. For this reason, there is no need to handle any other TLS model than local-exec. CloudABI's C library doesn't provide a __tls_get_addr() function to do Dynamic TLS. By forcing local-exec to be used here, we ensure that we don't generate function calls to __tls_get_addr().
bors
commented
Jan 5, 2018
☔ The latest upstream changes (presumably #47214) made this pull request unmergeable. Please resolve the merge conflicts. |
CloudABI doesn't do dynamic linking. For this reason, there is no need
to handle any other TLS model than local-exec. CloudABI's C library
doesn't provide a __tls_get_addr() function to do Dynamic TLS.
By forcing local-exec to be used here, we ensure that we don't generate
function calls to __tls_get_addr().