Restore working debuginfo tests by trimming comments from non-header directive lines by nerd2 · Pull Request #47155 · rust-lang/rust

nerd2 · 2018-01-03T15:06:34Z

I noticed when adding a debuginfo test that nothing I did caused the test to fail. Tracing back this seems to have been caused by 3e6c83d which broke parsing of the command/check lines, leaving all tests passing without any checking. This commit provides a basic (although still not very robust) restoration of tests and a should-fail test which checks the parser is running

…directive lines

rust-highfive · 2018-01-03T15:06:46Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2018-01-03T15:46:00Z

@bors: r+ p=1

Oh dear, thanks so much for catching this! Let's hope we haven't seen any regressions in the meantime...

cc @kennytm

bors · 2018-01-03T15:46:01Z

📌 Commit 28dd4d9 has been approved by alexcrichton

bors · 2018-01-03T15:54:00Z

⌛ Testing commit 28dd4d9 with merge 655dd55b5e1bd372709f744b577c96f609d91201...

bors · 2018-01-03T17:00:20Z

💔 Test failed - status-travis

nerd2 · 2018-01-03T17:34:54Z

Looks like a few failures on both GDB and LLDB. Do you want them fixed in this commit or marked ignore?

alexcrichton · 2018-01-03T17:54:51Z

If you know how to fix them that'd be great, otherwise we can open an issue and ignore them.

nerd2 · 2018-01-03T18:28:12Z

@alexcrichton updated this PR to disable them and created issue 47163 to track. Will update issue with ignored tests if this passes.

alexcrichton · 2018-01-03T18:49:32Z

@bors: r+

Ok, thanks!

bors · 2018-01-03T18:49:33Z

📌 Commit 3c2c978 has been approved by alexcrichton

bors · 2018-01-03T20:00:36Z

⌛ Testing commit 3c2c9780000169572fa1fb517fe26b0ebadca690 with merge 6664ed9ad4ee7b0093cde3b17794176fdf294092...

bors · 2018-01-03T21:06:18Z

💔 Test failed - status-travis

alexcrichton · 2018-01-03T21:13:53Z

A few missing tests?

[01:01:23] failures:
[01:01:23] [debuginfo-gdb] debuginfo/by-value-non-immediate-argument.rs
[01:01:23] [debuginfo-gdb] debuginfo/function-arg-initialization.rs
[01:01:23] [debuginfo-gdb] debuginfo/method-on-enum.rs
[01:01:23] [debuginfo-gdb] debuginfo/struct-in-enum.rs

alexcrichton · 2018-01-04T14:29:57Z

@bors: r+

bors · 2018-01-04T14:29:58Z

📌 Commit 970d332 has been approved by alexcrichton

bors · 2018-01-04T17:02:19Z

⌛ Testing commit 970d33261bd8db922f4631707c0d3ed32e2f06c2 with merge 1330a2f53f069a88c9758f2cb6ad61dea9c1e7fc...

bors · 2018-01-04T18:24:09Z

💔 Test failed - status-travis

nerd2 · 2018-01-04T18:29:41Z

A lot seems to be broken

kennytm · 2018-01-04T18:41:54Z

@bors r=alexcrichton p=15

bors · 2018-01-04T18:41:54Z

📌 Commit f025731 has been approved by alexchrichton

bors · 2018-01-04T18:42:13Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Remove impl Foo for .. {} in favor auto trait Foo {} #46480

bors · 2018-01-04T18:42:13Z

📌 Commit f025731 has been approved by alexcrichton

bors · 2018-01-04T19:22:26Z

⌛ Testing commit f025731a8c7d1befff81ee5e73e999063ceb1fcf with merge 1e66b606a7491b52f53db72a892bba6dff2c8cae...

bors · 2018-01-04T19:28:12Z

💔 Test failed - status-travis

kennytm · 2018-01-04T19:37:19Z

@bors retry

bors · 2018-01-04T22:35:56Z

⌛ Testing commit f025731a8c7d1befff81ee5e73e999063ceb1fcf with merge 04440cf853e3e16e5b942e38a9e880e93c6b139c...

bors · 2018-01-05T00:36:07Z

💔 Test failed - status-travis

kennytm · 2018-01-05T07:54:05Z

Why is this file added?

https://github.com/nerd2/rust/blob/57b4fb16a2475a1aee676ad4bc74bb10512ea367/test

kennytm · 2018-01-05T21:40:10Z

@bors r=alexcrichton

bors · 2018-01-05T21:40:11Z

📌 Commit 0a24acd has been approved by alexcrichton

bors · 2018-01-05T21:57:30Z

⌛ Testing commit 0a24acd with merge 327698f...

Restore working debuginfo tests by trimming comments from non-header directive lines I noticed when adding a debuginfo test that nothing I did caused the test to fail. Tracing back this seems to have been caused by 3e6c83d which broke parsing of the command/check lines, leaving all tests passing without any checking. This commit provides a basic (although still not very robust) restoration of tests and a should-fail test which checks the parser is running

bors · 2018-01-06T00:58:16Z

💔 Test failed - status-appveyor

kennytm · 2018-01-06T04:06:44Z

@bors retry #46903 (3 hour timeout)

bors · 2018-01-06T05:20:29Z

⌛ Testing commit 0a24acd with merge fdc6ca4...

Restore working debuginfo tests by trimming comments from non-header directive lines I noticed when adding a debuginfo test that nothing I did caused the test to fail. Tracing back this seems to have been caused by 3e6c83d which broke parsing of the command/check lines, leaving all tests passing without any checking. This commit provides a basic (although still not very robust) restoration of tests and a should-fail test which checks the parser is running

bors · 2018-01-06T08:01:40Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing fdc6ca4 to master...

Restore working debuginfo tests by trimming comments from non-header …
28dd4d9
…directive lines

rust-highfive assigned alexcrichton Jan 3, 2018

kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 3, 2018

nerd2 mentioned this pull request Jan 3, 2018
Some debuginfo tests are not running #47163
Closed

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 4, 2018

nerd2 force-pushed the debuginfo_test_fix branch from 3c2c978 to 970d332Compare January 4, 2018 10:52

nerd2 force-pushed the debuginfo_test_fix branch from 970d332 to f025731Compare January 4, 2018 18:29

nerd2 force-pushed the debuginfo_test_fix branch from f025731 to 57b4fb1Compare January 5, 2018 07:31

Disable failing tests temporarily
0a24acd

nerd2 force-pushed the debuginfo_test_fix branch from 57b4fb1 to 0a24acdCompare January 5, 2018 10:47

bors merged commit 0a24acd into rust-lang:masterJan 6, 2018

cbiffle mentioned this pull request Apr 5, 2022
Revert "Work around invalid DWARF bugs for fat LTO" #95685
Merged

Uh oh!

Uh oh!

Conversation

nerd2 commented Jan 3, 2018

Uh oh!

rust-highfive commented Jan 3, 2018

Uh oh!

alexcrichton commented Jan 3, 2018

Uh oh!

bors commented Jan 3, 2018

Uh oh!

bors commented Jan 3, 2018

Uh oh!

bors commented Jan 3, 2018

Uh oh!

nerd2 commented Jan 3, 2018

Uh oh!

alexcrichton commented Jan 3, 2018

Uh oh!

nerd2 commented Jan 3, 2018

Uh oh!

alexcrichton commented Jan 3, 2018

Uh oh!

bors commented Jan 3, 2018

Uh oh!

bors commented Jan 3, 2018

Uh oh!

bors commented Jan 3, 2018

Uh oh!

alexcrichton commented Jan 3, 2018

Uh oh!

alexcrichton commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

nerd2 commented Jan 4, 2018

Uh oh!

kennytm commented Jan 4, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

kennytm commented Jan 4, 2018

Uh oh!

bors commented Jan 4, 2018

Uh oh!

bors commented Jan 5, 2018

Uh oh!

kennytm commented Jan 5, 2018

Uh oh!

kennytm commented Jan 5, 2018

Uh oh!

bors commented Jan 5, 2018

Uh oh!

bors commented Jan 5, 2018

Uh oh!

bors commented Jan 6, 2018

Uh oh!

kennytm commented Jan 6, 2018

Uh oh!

bors commented Jan 6, 2018

Uh oh!

bors commented Jan 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

kennytm commented Jan 4, 2018•
edited
Loading