Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #47225
Merged
Merged
Conversation
GuillaumeGomez
commented
Jan 6, 2018
Member
- Successful merges: Minor rewrite of env::current_exe docs; clarify symlinks. #46987, [unix] Don't clone command-line args on startup #47165, Remove some outdated LLVM-related code #47173, Fix search bar defocus #47202, Clarify appending behavior of 'io::Read::read_to_string()'. #47216
- Failed merges:
- Update example in ‘security’ section to use hard links, like the linked securityvulns.com example. - Weaken language on symbolic links – indicate behavior is platform-specific Fixesrust-lang#43617.
The function was added as a wrapper to handle compatibility with older LLVM versions that we no longer support, so it can be removed. Refs rust-lang#46437
…ietMisdreavus Minor rewrite of env::current_exe docs; clarify symlinks. - Update example in ‘security’ section to use hard links, like the linked securityvulns.com example. - Weaken language on symbolic links – indicate behavior is platform-specific Fixesrust-lang#43617.
[unix] Don't clone command-line args on startup Fixes part of rust-lang#47164 and simplifies the `args` code on non-Apple Unix platforms. Note: This could change behavior for programs that use both `std::env::args` *and* unsafe code that mutates `argv` directly. However, these programs already behave differently on different platforms. The new behavior on non-Apple platforms is closer to the existing behavior on Apple platforms.
Remove some outdated LLVM-related code Ticks two boxes on rust-lang#46437
…Misdreavus Fix search bar defocus Fixesrust-lang#47134. r? @QuietMisdreavus
…acrum Clarify appending behavior of 'io::Read::read_to_string()'. A simple doc clarification.
GuillaumeGomez
commented
Jan 6, 2018
MemberAuthor
@bors: r+ p=1 |
rust-highfive
commented
Jan 6, 2018
Contributor
Some changes occurred in HTML/CSS. |
bors
commented
Jan 6, 2018
Collaborator
📌 Commit 35d1555 has been approved by |
rust-highfive
commented
Jan 6, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Jan 6, 2018
Collaborator
bors
commented
Jan 6, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jan 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.