Skip to content

Don't look for niches inside generator types. Fixes #47253 - #47270

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zoxc:gen-layout-fix
Jan 9, 2018
Merged

Don't look for niches inside generator types. Fixes #47253#47270
bors merged 1 commit into
rust-lang:masterfrom
Zoxc:gen-layout-fix

Conversation

@Zoxc

@ZoxcZoxc commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

@eddyb

eddyb commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 8, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 1a7b00d has been approved by eddyb

@eddybeddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 8, 2018
@Zoxc

Zoxc commented Jan 8, 2018

Copy link
Copy Markdown
ContributorAuthor

@eddyb You can't use generators on beta though?

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 8, 2018
@kennytmkennytm mentioned this pull request Jan 8, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 8, 2018
@kennytm
Rollup merge ofrust-lang#47270- Zoxc:gen-layout-fix, r=eddyb
9dd7cae
Don't look for niches inside generator types. Fixesrust-lang#47253
r? @eddyb
bors added a commit that referenced this pull request Jan 9, 2018
@bors
Auto merge of#47276- kennytm:rollup, r=kennytm
74966b5
Rollup of 10 pull requests
- Successful merges: #47210, #47233, #47246, #47254, #47256, #47258, #47259, #47263, #47270, #47272
- Failed merges: #47248
@bors
bors merged commit 1a7b00d into rust-lang:masterJan 9, 2018
@dwrenshadwrensha mentioned this pull request Jan 10, 2018
Open
@alexcrichton

alexcrichton commented Jan 10, 2018

Copy link
Copy Markdown
Member

@eddyb mind expanding a bit on the beta nomination? With what @Zoxc said we may not wish to beta nominate?

@eddyb

eddyb commented Jan 10, 2018

Copy link
Copy Markdown
Contributor

@alexcrichton Sure, assuming no code in the standard library or the compiler uses generators.

@alexcrichton

alexcrichton commented Jan 10, 2018

Copy link
Copy Markdown
Member

Indeed! Ok removing nomination.

@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zoxc@eddyb@bors@alexcrichton@kennytm