Skip to content

Allow a trailing comma in lint_array - #47458

Merged
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:lint_array_comma
Jan 17, 2018
Merged

Allow a trailing comma in lint_array#47458
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:lint_array_comma

Conversation

@mark-i-m

@mark-i-mmark-i-m commented Jan 15, 2018

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Jan 15, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mark-i-m

mark-i-m commented Jan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @durka

durka
durka reviewed Jan 15, 2018
View reviewed changes
Comment threadsrc/librustc/lint/mod.rs Outdated

@durkadurkaJan 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add a & here?

@mark-i-mmark-i-mJan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch... Copy/paste 🤕

@mark-i-mmark-i-mJan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks @durka !

@durka

durka commented Jan 15, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM, I'm not a reviewer though. You should probably add a test for the trailing comma? Perhaps in src/test/run-pass-fulldeps/auxiliary/lint_for_crate.rs.

@mark-i-m

mark-i-m commented Jan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks, I added a couple of tests...

@mark-i-m

mark-i-m commented Jan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Hmm... ok... I need to fix a couple of errors.

@mark-i-m

mark-i-m commented Jan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Ok, I think they should actually work now

@mark-i-m

mark-i-m commented Jan 16, 2018

Copy link
Copy Markdown
ContributorAuthor

@estebank ping :)

@estebank

estebank commented Jan 16, 2018

Copy link
Copy Markdown
Contributor

@mark-i-m one final nitpick and r=me. Could you squash all your commits into one?

@mark-i-m

mark-i-m commented Jan 16, 2018

Copy link
Copy Markdown
ContributorAuthor

@estebank Squashed :)

Thanks!

@estebank

estebank commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jan 17, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f81c2de has been approved by estebank

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 17, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 17, 2018
@kennytm
Rollup merge ofrust-lang#47458- mark-i-m:lint_array_comma, r=estebank
4b77463
Allow a trailing comma in lint_array
fixrust-lang#47428
@kennytmkennytm mentioned this pull request Jan 17, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 17, 2018
@kennytm
Rollup merge ofrust-lang#47458- mark-i-m:lint_array_comma, r=estebank
4b636d0
Allow a trailing comma in lint_array
fixrust-lang#47428
@kennytmkennytm mentioned this pull request Jan 17, 2018
Merged
bors added a commit that referenced this pull request Jan 17, 2018
@bors
Auto merge of#47522- kennytm:rollup, r=kennytm
0f9c784
Rollup of 21 pull requests
- Successful merges: #47302, #47333, #47387, #47404, #47407, #47426, #47427, #47436, #47444, #47456, #47458, #47467, #47479, #47481, #47483, #47487, #47497, #47498, #47505, #47509, #47514
- Failed merges:
@bors
bors merged commit f81c2de into rust-lang:masterJan 17, 2018
@mark-i-m
mark-i-m deleted the lint_array_comma branch November 14, 2018 16:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@durkadurkadurka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support trailing commas in lint_array

6 participants

@mark-i-m@rust-highfive@durka@estebank@bors@kennytm