Uh oh!
There was an error while loading. Please reload this page.
Don't include DefIndex in proc-macro registrar function symbol. - #47494
Merged
Conversation
rust-highfive
commented
Jan 16, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
approved these changes
Jan 16, 2018
nikomatsakis
commented
Jan 16, 2018
Contributor
@bors r+ |
bors
commented
Jan 16, 2018
Collaborator
📌 Commit 42ea668 has been approved by |
michaelwoeristerforce-pushed
the
proc-macro-incremental
branch
from
January 16, 2018 18:31
42ea668 to
f0a7d8eComparemichaelwoerister
commented
Jan 16, 2018
MemberAuthor
@bors r=nikomatsakis (fixed the failing test) |
bors
commented
Jan 16, 2018
Collaborator
📌 Commit f0a7d8e has been approved by |
alexcrichton
commented
Jan 16, 2018
Member
@michaelwoerister since incremental is on beta, any objections to backporting? |
michaelwoerister
commented
Jan 17, 2018
MemberAuthor
Once we confirm that it actually fixes the issue, I'm all for backporting. |
michaelwoerister
commented
Jan 17, 2018
MemberAuthor
@bors p=1 (since this is a bug fix that we probably want to backport) |
bors
commented
Jan 19, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jan 19, 2018
…omatsakis Don't include DefIndex in proc-macro registrar function symbol. There can only ever be one registrar function per plugin or proc-macro crate, so adding the `DefIndex` to the function's symbol name does not serve a real purpose. Remove the `DefIndex` from the symbol name makes it stable across incremental compilation sessions. This should fix issue #47292.
bors
commented
Jan 19, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can only ever be one registrar function per plugin or proc-macro crate, so adding the
DefIndexto the function's symbol name does not serve a real purpose. Remove theDefIndexfrom the symbol name makes it stable across incremental compilation sessions.This should fix issue #47292.