Skip to content

[beta] Attempt to fix prerelease version calculation - #47546

Closed
alexcrichton wants to merge 1 commit into
rust-lang:betafrom
alexcrichton:fix-beta
Closed

[beta] Attempt to fix prerelease version calculation#47546
alexcrichton wants to merge 1 commit into
rust-lang:betafrom
alexcrichton:fix-beta

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

We got #47396 merged but it looks like rcs failed to deploy the beta because
when it tried to calculate the beta version its cwd was different. Let's try to
fix this bug and fix auto-deploy by explicitly setting the current_dir for git
commands.

We got rust-lang#47396 merged but it looks like rcs failed to deploy the beta because
when it tried to calculate the beta version its cwd was different. Let's try to
fix this bug and fix auto-deploy by explicitly setting the `current_dir` for git
commands.
@alexcrichton

Copy link
Copy Markdown
MemberAuthor

r? @kennytm

@alexcrichton

Copy link
Copy Markdown
MemberAuthor

Looks like the beta was calculated as 1.24.0-beta.5 (597549eff 2018-01-18) though so it appears to be working otherwise!

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2018
@kennytm

Copy link
Copy Markdown
Member

@bors r+ p=1

@bors

bors commented Jan 18, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit b67cb01 has been approved by kennytm

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2018
@alexcrichton

Copy link
Copy Markdown
MemberAuthor

I'm gonna close in favor of #47553 as the queue's a little slow now...

bors added a commit that referenced this pull request Jan 18, 2018
[beta] Rollup + backports
This is a rollup of two PRs:
* #47546
* #47431
and a backport of two PRs:
* #47505
* #47220
@alexcrichton
alexcrichton deleted the fix-beta branch March 19, 2018 17:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcrichton@kennytm@bors