Skip to content

Add regression test for #29723 - #47549

Merged
bors merged 4 commits into
rust-lang:masterfrom
Manishearth:29723-regression
Jan 23, 2018
Merged

Add regression test for #29723#47549
bors merged 4 commits into
rust-lang:masterfrom
Manishearth:29723-regression

Conversation

@Manishearth

@ManishearthManishearth commented Jan 18, 2018•
edited by nikomatsakis
Loading

Copy link
Copy Markdown
Member

@ManishearthManishearth mentioned this pull request Jan 18, 2018
Closed
@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2018
kennytm
kennytm reviewed Jan 18, 2018
View reviewed changes
Comment threadsrc/test/ui/issue-29723.rs Outdated

@kennytmkennytmJan 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[00:04:49] tidy error: /checkout/src/test/ui/issue-29723.rs: missing trailing newline

@Manishearth

Manishearth commented Jan 19, 2018

Copy link
Copy Markdown
MemberAuthor

fixed

@nikomatsakis

nikomatsakis commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

missing main function

@nikomatsakis

nikomatsakis commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

r=me once travis is green -- probably just change foo to main, no?

@nikomatsakis

nikomatsakis commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

I did it myself :)

@kennytm

kennytm commented Jan 21, 2018

Copy link
Copy Markdown
Member

@bors r=nikomatsakis

@bors

bors commented Jan 21, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 67f922b has been approved by nikomatsakis

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2018
@frewsxcv

frewsxcv commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Jan 23, 2018
@kennytm
Rollup merge ofrust-lang#47549- Manishearth:29723-regression, r=nik…
658ccae
…omatsakis
Add regression test for rust-lang#29723
cc rust-lang#29723
r? @nikomatsakis
@kennytmkennytm mentioned this pull request Jan 23, 2018
Merged
bors added a commit that referenced this pull request Jan 23, 2018
@bors
Auto merge of#47678- kennytm:rollup, r=kennytm
4e3901d
Rollup of 14 pull requests
- Successful merges: #47423, #47425, #47440, #47541, #47549, #47554, #47558, #47610, #47635, #47655, #47661, #47662, #47667, #47672
- Failed merges:
@bors
bors merged commit 67f922b into rust-lang:masterJan 23, 2018
@matthewjaspermatthewjasper mentioned this pull request Apr 24, 2018
Closed
@pnkfelixpnkfelix mentioned this pull request Aug 17, 2021
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytmkennytmkennytm left review comments

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Manishearth@nikomatsakis@kennytm@bors@frewsxcv