Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Remove methods from #[doc(masked)] crates from the search index - #47675
Merged
Conversation
kennytm
commented
Jan 23, 2018
Member
Could you verify if this fixes #44740? |
ollie27
commented
Jan 23, 2018
ContributorAuthor
Indeed it does. |
QuietMisdreavus
commented
Jan 23, 2018
Contributor
@bors r+ rollup Thanks! |
bors
commented
Jan 23, 2018
Collaborator
📌 Commit 2e81ce7 has been approved by |
kennytm
commented
Jan 25, 2018
Member
@bors r- Not your fault, but unfortunately a test case is invalid, causing failure after the bug is fixed. Please apply the following diff: diff --git a/src/test/rustdoc-js/from_u.js b/src/test/rustdoc-js/from_u.js
index 0296788f7a..34b98a758d 100644
--- a/src/test/rustdoc-js/from_u.js+++ b/src/test/rustdoc-js/from_u.js@@ -15,7 +15,5 @@ const EXPECTED = {
{ 'path': 'std::char', 'name': 'from_u32' },
{ 'path': 'std::str', 'name': 'from_utf8' },
{ 'path': 'std::string::String', 'name': 'from_utf8' },
- { 'path': 'std::i32', 'name': 'from_unsigned' },- { 'path': 'std::i128', 'name': 'from_unsigned' },
],
}; |
kennytm
commented
Jan 25, 2018
Member
@bors r=QuietMisdreavus |
bors
commented
Jan 25, 2018
Collaborator
📌 Commit 77bc826 has been approved by |
ollie27
commented
Jan 25, 2018
ContributorAuthor
Is it possible for travis to run those tests automatically? They seem like they will be pretty fragile. |
Member
@ollie27 Those tests should be run automatically, but it seems the CI docker image is missing nodejs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example: https://doc.rust-lang.org/nightly/std/?search=from_parts
Fixes#44740
r? @QuietMisdreavus