Uh oh!
There was an error while loading. Please reload this page.
Fix regression: account for impl methods in arg count mismatch error - #47747
Merged
Conversation
rust-highfive
commented
Jan 25, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Jan 25, 2018
Contributor
@bors r+ |
bors
commented
Jan 25, 2018
Collaborator
📌 Commit 6006b67 has been approved by |
estebank
commented
Jan 25, 2018
ContributorAuthor
@bors rollup |
nikomatsakis
commented
Jan 26, 2018
Contributor
I don't think this should be a rollup -- it fixes a regression, after all. |
Contributor
Well, I guess it depends what rollup means. I tend to think of it as "low risk and it lands when it lands", but maybe that's not quite right. |
estebank
commented
Jan 26, 2018
ContributorAuthor
My rationale was that it had a better chance of landing sooner without giving it a higher priority, given that it is a small change and didn't want to take a while slot for it. Feel free to change it removing the rollup and increasing the priority. |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Jan 31, 2018
Fix regression: account for trait methods in arg count mismatch error Fixedrust-lang#47706 (rust-lang#47706 (comment)) Original PR rust-lang#47747 missed methods on trait definitions. This edit was done in GitHub. I think I got the signature of the variant right, going by the ICE debug output and the other cases above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#47706.