Skip to content

Adding ICH to the glossary. - #47795

Merged
bors merged 1 commit into
rust-lang:masterfrom
avborhanian:master
Jan 31, 2018
Merged

Adding ICH to the glossary.#47795
bors merged 1 commit into
rust-lang:masterfrom
avborhanian:master

Conversation

@avborhanian

@avborhanianavborhanian commented Jan 27, 2018

Copy link
Copy Markdown
Contributor

In regards to issue #47782

@rust-highfive

rust-highfive commented Jan 27, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytmkennytm mentioned this pull request Jan 28, 2018
Closed
@kennytm

kennytm commented Jan 31, 2018

Copy link
Copy Markdown
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @pnkfelix or someone else from the team reviews it soon.

@kennytmkennytm added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2018
@hanna-kruppe

hanna-kruppe commented Jan 31, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jan 31, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 0984ee3 has been approved by rkruppe

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 31, 2018
@kennytm
Rollup merge ofrust-lang#47795- avborhanian:master, r=rkruppe
64fc9d2
Adding ICH to the glossary.
Fixesrust-lang#47782.
@kennytmkennytm mentioned this pull request Jan 31, 2018
Merged
bors added a commit that referenced this pull request Jan 31, 2018
@bors
Auto merge of#47900- kennytm:rollup, r=kennytm
8ccab7e
Rollup of 16 pull requests
- Successful merges: #47838, #47840, #47844, #47874, #47875, #47876, #47884, #47886, #47889, #47890, #47891, #47795, #47677, #47893, #47895, #47552
- Failed merges:
@bors
bors merged commit 0984ee3 into rust-lang:masterJan 31, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@avborhanian@rust-highfive@kennytm@hanna-kruppe@bors@pnkfelix