Do not enable ThinLTO on stable, beta, or nightly builds. by Mark-Simulacrum · Pull Request #47834 · rust-lang/rust

Mark-Simulacrum · 2018-01-28T22:53:20Z

Fixes#45444

rust-highfive · 2018-01-28T22:53:24Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2018-01-28T22:53:38Z

Not sure if we want to disable this for nightly builds, but the other two I feel fairly confident about.

Mark-Simulacrum · 2018-01-28T22:53:48Z

r? @alexcrichton

alexcrichton · 2018-01-29T01:14:34Z

Thanks! I think we want to keep this enabled though for the rest of CI? I think as-is it'd blanket turn it off on Travis/AppVeyor?

Mark-Simulacrum · 2018-01-29T01:27:31Z

So keep ThinLTO on for nightly but not beta and stable? I am okay with that.

alexcrichton · 2018-01-29T06:03:25Z

Hm actually, how about an off-by-default option enabled here which is our area for "produce a release config flags to pass" stuff

Mark-Simulacrum · 2018-02-02T18:46:01Z

@bors try -- to test and make sure that nothing breaks on dist builds

bors · 2018-02-02T18:46:11Z

⌛ Trying commit bbb9860 with merge d2192a1...

Do not enable ThinLTO on stable, beta, or nightly builds. Developers testing locally (-dev profile) may want faster builds for slightly slower compilers (~5%) whereas dist builds should always be as fast as we can make them, and since those run on CI we don't care quite as much for the build being somewhat slower. As such, we don't automatically enable ThinLTO on builds for the stable, beta, or nightly channels. Fixes#45444

bors · 2018-02-02T18:54:21Z

💔 Test failed - status-travis

ollie27 · 2018-02-02T18:57:42Z

Won't you need to specify 1 codegen unit as rustc defaults to 16 now or am I missing something?

kennytm · 2018-02-03T11:33:43Z

@bors try

bors · 2018-02-03T11:33:53Z

⌛ Trying commit 08159e9 with merge 20e1b39...

Do not enable ThinLTO on stable, beta, or nightly builds. Developers testing locally (-dev profile) may want faster builds for slightly slower compilers (~5%) whereas dist builds should always be as fast as we can make them, and since those run on CI we don't care quite as much for the build being somewhat slower. As such, we don't automatically enable ThinLTO on builds for the stable, beta, or nightly channels. Fixes#45444

bors · 2018-02-03T13:51:24Z

☀️ Test successful - status-travis
State: approved= try=True

Mark-Simulacrum · 2018-02-03T15:41:20Z

@alexcrichton Ready for another review.

alexcrichton · 2018-02-03T23:12:08Z

 set(&mut config.quiet_tests, rust.quiet_tests);
 set(&mut config.test_miri, rust.test_miri);
 set(&mut config.wasm_syscall, rust.wasm_syscall);
+ config.rust_thinlto = rust.thinlto.unwrap_or(true);


I think this section will only get hit if rust is Some (which it may not be), so could the default-true initialization happen sooner?

alexcrichton · 2018-02-03T23:13:10Z

I think due to the change in defaults in rustc this ay also not work? When thinlto is disabled I think we'll want to basically pass -C codegen-units=1 to rustc, right?

Dist builds should always be as fast as we can make them, and since those run on CI we don't care quite as much for the build being somewhat slower. As such, we don't automatically enable ThinLTO on builds for the dist builders.

Mark-Simulacrum · 2018-02-04T01:39:19Z

Updated to pass the 1-codegen-unit option to rustc.

alexcrichton · 2018-02-04T14:54:37Z

@bors: r+

bors · 2018-02-04T14:54:37Z

📌 Commit e1f04c0 has been approved by alexcrichton

bors · 2018-02-04T15:06:12Z

⌛ Testing commit e1f04c0 with merge 0c6091f...

Do not enable ThinLTO on stable, beta, or nightly builds. Fixes#45444

bors · 2018-02-04T17:58:12Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0c6091f to master...

Mark-Simulacrum assigned alexcrichton Jan 28, 2018

rust-highfive assigned aturon and unassigned alexcrichton Jan 28, 2018

Mark-Simulacrum unassigned aturon Jan 28, 2018

rust-highfive assigned alexcrichton Jan 28, 2018

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2018

Mark-Simulacrum added this to the 1.24 milestone Jan 31, 2018

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2018

Mark-Simulacrum force-pushed the no-cgu-release branch 2 times, most recently from 7301e14 to bbb9860Compare February 2, 2018 18:45

Mark-Simulacrum force-pushed the no-cgu-release branch from bbb9860 to 08159e9Compare February 3, 2018 01:31

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 3, 2018

alexcrichton reviewed Feb 3, 2018
View reviewed changes

Disable ThinLTO for dist builds.
e1f04c0
Dist builds should always be as fast as we can make them, and since those run on CI we don't care quite as much for the build being somewhat slower. As such, we don't automatically enable ThinLTO on builds for the dist builders.

Mark-Simulacrum force-pushed the no-cgu-release branch from 08159e9 to e1f04c0Compare February 4, 2018 01:38

bors added a commit that referenced this pull request Feb 4, 2018
Auto merge of#47834- Mark-Simulacrum:no-cgu-release, r=alexcrichton
0c6091f
Do not enable ThinLTO on stable, beta, or nightly builds. Fixes#45444

bors merged commit e1f04c0 into rust-lang:masterFeb 4, 2018

aidanhs mentioned this pull request Feb 5, 2018
compiletest: Default to one CGU when compiling tests. #47779
Closed

tjkirch mentioned this pull request Mar 15, 2018
aarch64 musl binaries panic since 2018-02-05 nightly #48967
Closed

Mark-Simulacrum deleted the no-cgu-release branch June 8, 2019 13:51

Uh oh!

Uh oh!

Conversation

Mark-Simulacrum commented Jan 28, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jan 28, 2018

Uh oh!

Mark-Simulacrum commented Jan 28, 2018

Uh oh!

Mark-Simulacrum commented Jan 28, 2018

Uh oh!

alexcrichton commented Jan 29, 2018

Uh oh!

Mark-Simulacrum commented Jan 29, 2018

Uh oh!

alexcrichton commented Jan 29, 2018

Uh oh!

Mark-Simulacrum commented Feb 2, 2018

Uh oh!

bors commented Feb 2, 2018

Uh oh!

bors commented Feb 2, 2018

Uh oh!

ollie27 commented Feb 2, 2018

Uh oh!

kennytm commented Feb 3, 2018

Uh oh!

bors commented Feb 3, 2018

Uh oh!

bors commented Feb 3, 2018

Uh oh!

Mark-Simulacrum commented Feb 3, 2018

Uh oh!

alexcrichtonFeb 3, 2018

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Feb 3, 2018

Uh oh!

Mark-Simulacrum commented Feb 4, 2018

Uh oh!

alexcrichton commented Feb 4, 2018

Uh oh!

bors commented Feb 4, 2018

Uh oh!

bors commented Feb 4, 2018

Uh oh!

bors commented Feb 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Mark-Simulacrum commented Jan 28, 2018•
edited
Loading