Skip to content

Update ops range example to avoid confusion between indexes and values. - #48151

Merged
kennytm merged 1 commit into
rust-lang:masterfrom
echochamber:update_range_example
Feb 15, 2018
Merged

Update ops range example to avoid confusion between indexes and values.#48151
kennytm merged 1 commit into
rust-lang:masterfrom
echochamber:update_range_example

Conversation

@echochamber

@echochamberechochamber commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Makes clearer the numbers in the range refer to indexes, not the values at those indexes.

@rust-highfive

rust-highfive commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@estebank

estebank commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit bd426f1 has been approved by estebank

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2018
@kennytmkennytm mentioned this pull request Feb 12, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Feb 12, 2018
@kennytm
Rollup merge ofrust-lang#48151- echochamber:update_range_example, r…
b4b49eb
…=estebank Update ops range example to avoid confusion between indexes and values. Makes clearer the numbers in the range refer to indexes, not the values at those indexes.
bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of#48158- kennytm:rollup, r=kennytm
710e972
Rollup of 8 pull requests
- Successful merges: #47846, #48033, #48087, #48114, #48126, #48130, #48133, #48151
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 13, 2018
@kennytm
Rollup merge ofrust-lang#48151- echochamber:update_range_example, r…
c67b789
…=estebank
Update ops range example to avoid confusion between indexes and values.
Makes clearer the numbers in the range refer to indexes, not the values at those indexes.
@kennytmkennytm mentioned this pull request Feb 13, 2018
Closed
bors added a commit that referenced this pull request Feb 13, 2018
@bors
Auto merge of#48177- kennytm:rollup, r=kennytm
1811c36
Rollup of 14 pull requests
- Successful merges: #47784, #47846, #48033, #48083, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48163, #48165, #48167
- Failed merges:
@kennytmkennytm mentioned this pull request Feb 14, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 14, 2018
@kennytm
Rollup merge ofrust-lang#48151- echochamber:update_range_example, r…
c4b211b
…=estebank
Update ops range example to avoid confusion between indexes and values.
Makes clearer the numbers in the range refer to indexes, not the values at those indexes.
bors added a commit that referenced this pull request Feb 14, 2018
@bors
Auto merge of#48203- kennytm:rollup, r=kennytm
d3fb063
Rollup of 22 pull requests
- Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035
- Failed merges:
@echochamber

echochamber commented Feb 14, 2018

Copy link
Copy Markdown
ContributorAuthor

@estebank Looks like bors has rolled this up. Should I close this PR?

@estebank

estebank commented Feb 14, 2018

Copy link
Copy Markdown
Contributor

@echochamber leave it, the rollup PR hasn't been merged yet. Once it gets merged, this PR will get closed automatically.

bors added a commit that referenced this pull request Feb 15, 2018
@bors
Auto merge of#48203- kennytm:rollup, r=kennytm
f6ee1ec
Rollup of 22 pull requests
- Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035
- Failed merges:
@echochamber

echochamber commented Feb 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Sounds good. Thanks.

bors added a commit that referenced this pull request Feb 15, 2018
@bors
Auto merge of#48203- kennytm:rollup, r=kennytm
1670a53
Rollup of 23 pull requests
- Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035, #48210
- Failed merges:
@kennytm
kennytm merged commit bd426f1 into rust-lang:masterFeb 15, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushiBurntSushi

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@echochamber@rust-highfive@estebank@bors@kennytm@BurntSushi