Skip to content

Update RLS - #48202

Merged
bors merged 2 commits into
rust-lang:masterfrom
nrc:update
Feb 15, 2018
Merged

Update RLS#48202
bors merged 2 commits into
rust-lang:masterfrom
nrc:update

Conversation

@nrc

@nrcnrc commented Feb 14, 2018

Copy link
Copy Markdown
Member

Should fix the RLS test breakage.

r? @alexcrichton

@nrcnrc mentioned this pull request Feb 14, 2018
Merged
@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2018
@kennytm

kennytm commented Feb 14, 2018

Copy link
Copy Markdown
Member

@bors r+ p=3

@bors

bors commented Feb 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit fa94c5c has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2018
@bors

bors commented Feb 14, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fa94c5c with merge 234e7736ad7fc031454444a4c61441fed183b1a2...

@bors

bors commented Feb 14, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2018
@kennytm

kennytm commented Feb 14, 2018

Copy link
Copy Markdown
Member

distcheck failed, clippy_lints needs to be exempted (make sure clippy_lints is not used by libcore/liballoc/libstd, and then edit src/tools/tidy/src/deps.rs)

[00:36:43] invalid license MPL-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/clippy_lints/Cargo.toml
[00:36:43] some tidy checks failed

@kennytmkennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2018
@Mark-Simulacrum

Mark-Simulacrum commented Feb 14, 2018

Copy link
Copy Markdown
Member

@bors r=kennytm p=5

Excluded clippy_lints.

@bors

bors commented Feb 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 45944f6 has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2018
@bors

bors commented Feb 14, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 45944f6 with merge 236d32fa637e20f0412865449cf3e565cfd3969c...

@bors

bors commented Feb 15, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@Mark-Simulacrum

Mark-Simulacrum commented Feb 15, 2018

Copy link
Copy Markdown
Member

@bors retry - appveyor timed out

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018
@bors

bors commented Feb 15, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 45944f6 with merge 90759be...

bors added a commit that referenced this pull request Feb 15, 2018
@bors
Auto merge of#48202- nrc:update, r=kennytm
90759be
Update RLS
Should fix the RLS test breakage.
r? @alexcrichton
@bors

bors commented Feb 15, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 90759be to master...

@bors
bors merged commit 45944f6 into rust-lang:masterFeb 15, 2018
@borsbors mentioned this pull request Feb 15, 2018
Closed
kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 15, 2018
@kennytm-githubbot
📣 Toolstate changed byrust-lang/rust#48202!
31e5eba
Tested on commit rust-lang/rust@90759be.
🎉 rls on windows: test-fail → test-pass.
🎉 rls on linux: test-fail → test-pass.
@borsbors mentioned this pull request Feb 15, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nrc@kennytm@bors@Mark-Simulacrum@alexcrichton