Uh oh!
There was an error while loading. Please reload this page.
Turn feature-gate table into a query so it is covered by dependency tracking. - #48208
Merged
Merged
Conversation
rust-highfive
commented
Feb 14, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
michaelwoeristerforce-pushed
the
track-features
branch
2 times, most recently
from
February 15, 2018 13:29
23a0009 to
c0517a3Comparepetrochenkov
commented
Feb 15, 2018
Contributor
@bors r+ |
bors
commented
Feb 15, 2018
Collaborator
📌 Commit d691c46 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Feb 19, 2018
…petrochenkov Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixesrust-lang#47003.
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Feb 20, 2018
…petrochenkov Fixesrust-lang#47311. r? @nrc
bors added a commit
that referenced
this pull request
Feb 20, 2018
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2018
…petrochenkov Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixesrust-lang#47003.
bors added a commit
that referenced
this pull request
Feb 24, 2018
bors
commented
Mar 3, 2018
Collaborator
☔ The latest upstream changes (presumably #48586) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoeristerforce-pushed
the
track-features
branch
from
March 5, 2018 10:05
4fd260d to
93625f1Comparemichaelwoerister
commented
Mar 5, 2018
MemberAuthor
Rebased. @bors r=petrochenkov |
bors
commented
Mar 5, 2018
Collaborator
📌 Commit 93625f1 has been approved by |
bors
commented
Mar 5, 2018
Collaborator
bors added a commit
that referenced
this pull request
Mar 5, 2018
Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes#47003.
bors
commented
Mar 5, 2018
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Mar 5, 2018
Member
This was referenced Mar 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn access to feature gates into a query so we handle them correctly during incremental compilation.
Features are still available via
Sessionthroughfeatures_untracked(). I wish we had a better way of hiding untracked information. It would be great if we could remove thesessfield fromTyCtxt.Fixes#47003.