Uh oh!
There was an error while loading. Please reload this page.
Clarify "It is an error to..." wording for zero-duration behaviors. - #48328
Merged
bors merged 1 commit intoMar 3, 2018
Merged
Conversation
rust-highfive
commented
Feb 18, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
commented
Feb 18, 2018
ContributorAuthor
r? @sfackler i'm interested in doing the integration test thing you mentioned in the github issue, but i'll do that in a separate pr |
frewsxcvforce-pushed
the
frewsxcv-clarify-error-zero-duration
branch
from
February 18, 2018 19:22
88973b6 to
19fa3daCompareMember
There was a problem hiding this comment.
I don't know if we need to have an explicit example of an invalid call.
Contributor
There was a problem hiding this comment.
We talked about it at the docs team meeting, and everyone was generally in favor of showing off error conditions.
frewsxcvforce-pushed
the
frewsxcv-clarify-error-zero-duration
branch
from
February 19, 2018 16:22
19fa3da to
bb2fae6Comparefrewsxcvforce-pushed
the
frewsxcv-clarify-error-zero-duration
branch
from
February 22, 2018 13:04
bb2fae6 to
931087cComparebors
commented
Feb 22, 2018
Collaborator
☔ The latest upstream changes (presumably #48399) made this pull request unmergeable. Please resolve the merge conflicts. |
Documentation fix side of rust-lang#48311.
frewsxcvforce-pushed
the
frewsxcv-clarify-error-zero-duration
branch
from
February 24, 2018 13:57
931087c to
0700bd1Comparefrewsxcv
commented
Feb 25, 2018
ContributorAuthor
tests are passing now, let me know if anyone sees anything else! |
shepmaster
commented
Mar 2, 2018
Member
Heads-up @sfackler, this is ready for re-review. |
sfackler
commented
Mar 3, 2018
Member
@bors r+ |
bors
commented
Mar 3, 2018
Collaborator
📌 Commit 0700bd1 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Mar 3, 2018
…o-duration, r=sfackler Fixesrust-lang#47311. r? @nrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation fix side of #48311.