[beta] temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251 by nikomatsakis · Pull Request #48379 · rust-lang/rust

nikomatsakis · 2018-02-20T18:29:35Z

see also #48378

r? @Mark-Simulacrum

rust-highfive · 2018-02-20T18:29:45Z

Warning

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

nikomatsakis · 2018-02-21T21:12:55Z

See FCP on the stable PR

Mark-Simulacrum · 2018-02-23T01:21:28Z

@bors r+ p=1

bors · 2018-02-23T01:21:29Z

📌 Commit 61c2258 has been approved by Mark-Simulacrum

bors · 2018-02-23T05:19:56Z

⌛ Testing commit 61c2258 with merge d27e1b5dcbe37e9b05ce44db85ab384056ab4564...

bors · 2018-02-23T08:20:25Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2018-02-23T18:31:55Z

@bors retry appveyor timed out

bors · 2018-02-24T10:50:19Z

⌛ Testing commit 61c2258 with merge 4d3a6ef1c08b45151bcb38cb516f0e05a154d2a9...

bors · 2018-02-24T13:52:48Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2018-02-24T14:59:28Z

@bors retry

We need to backport the appveyor fix to beta...

kennytm · 2018-02-24T19:30:56Z

@bors p=8

Beta backport

Manishearth · 2018-02-24T20:49:37Z

@bors p=10

(we care about this one more)

bors · 2018-02-25T15:04:37Z

💔 Test failed - status-travis

kennytm · 2018-02-25T15:22:02Z

@bors retry

3 hour timeout in asmjs

Timing breakdown:

Step	Duration (s)
make-prepare	69.27
pytest/bootstrap	0
stage0-std	78.82
stage0-test	14.64
stage0-rustc	1107.11
llvm	358.52
stage0-trans-llvm	193.11
llvm-emscripten	166.46
stage0-trans-emscripten	87.76
stage1-std	102.85
stage1-test	24.24
stage1-rustc	1788.3
stage1-trans-llvm	233.64
stage1-trans-emscripten	129.35
stage2-std	74.9
stage2-test	16.56
stage0-compiletest	57.49
test/ui	159.54
test/run-pass	4752.34
test/compile-fail	142.39
test/parse-fail	5.4
test/run-fail	217.03
test/run-pass-valgrind	18.75
test/mir-opt	85.68
test/codegen	8.4
test/codegen-units	26.41
test/incremental	172.62
test/debuginfo	0.21

run-pass tests taking 1 hr 18 min to complete? 🤔

bors · 2018-02-25T17:48:43Z

⌛ Testing commit 61c2258 with merge c13785b789c3855430dab856d5ca57587e378d99...

bors · 2018-02-25T20:49:13Z

💔 Test failed - status-appveyor

kennytm · 2018-02-26T10:52:59Z

@bors retry #46903

bors · 2018-02-26T15:27:27Z

⌛ Testing commit 61c2258 with merge 62ad16c...

@Mark-Simulacrum

[beta] temporarily disable #46833 due to #48251 see also #48378 r? @Mark-Simulacrum

bors · 2018-02-26T18:27:58Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2018-02-26T18:38:59Z

@bors retry -- appveyor timed out

bors · 2018-02-26T21:29:14Z

⌛ Testing commit 61c2258 with merge bcbe7c27325161856c25b04fa95bb5c69d4dc5b0...

bors · 2018-02-27T00:29:46Z

💔 Test failed - status-appveyor

alexcrichton · 2018-02-27T00:41:03Z

All dist jobs completed for 62ad16c

gonna merge that manually

rust-highfive assigned Mark-Simulacrum Feb 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2018

temporarily disablerust-lang#46833due torust-lang#48251
61c2258

nikomatsakis force-pushed the issue-48251-beta branch from 536cd89 to 61c2258Compare February 20, 2018 21:17

nikomatsakis mentioned this pull request Feb 21, 2018
Revert rust-lang/rust#46833 on stable #48378
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2018

Manishearth changed the title ~~temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251~~[beta] temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251Feb 24, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018

bors added a commit that referenced this pull request Feb 26, 2018
Auto merge of#48379- nikomatsakis:issue-48251-beta, r=Mark-Simulacrum
62ad16c
[beta] temporarily disable #46833 due to #48251 see also #48378 r? @Mark-Simulacrum

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018

alexcrichton merged commit 61c2258 into rust-lang:betaFeb 27, 2018

Uh oh!

Uh oh!

Conversation

nikomatsakis commented Feb 20, 2018

Uh oh!

rust-highfive commented Feb 20, 2018

Uh oh!

nikomatsakis commented Feb 21, 2018

Uh oh!

Mark-Simulacrum commented Feb 23, 2018

Uh oh!

bors commented Feb 23, 2018

Uh oh!

bors commented Feb 23, 2018

Uh oh!

bors commented Feb 23, 2018

Uh oh!

Mark-Simulacrum commented Feb 23, 2018

Uh oh!

bors commented Feb 24, 2018

Uh oh!

bors commented Feb 24, 2018

Uh oh!

Mark-Simulacrum commented Feb 24, 2018

Uh oh!

kennytm commented Feb 24, 2018

Uh oh!

Manishearth commented Feb 24, 2018

Uh oh!

bors commented Feb 25, 2018

Uh oh!

kennytm commented Feb 25, 2018

Uh oh!

bors commented Feb 25, 2018

Uh oh!

bors commented Feb 25, 2018

Uh oh!

kennytm commented Feb 26, 2018

Uh oh!

bors commented Feb 26, 2018

Uh oh!

bors commented Feb 26, 2018

Uh oh!

Mark-Simulacrum commented Feb 26, 2018

Uh oh!

bors commented Feb 26, 2018

Uh oh!

bors commented Feb 27, 2018

Uh oh!

alexcrichton commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants