Uh oh!
There was an error while loading. Please reload this page.
Add root-path - #48442
Closed
GuillaumeGomez wants to merge 1 commit into
Closed
Conversation
GuillaumeGomezforce-pushed
the
root-path
branch
from
February 22, 2018 23:18
74a5087 to
2059400Compareonur
commented
Feb 23, 2018
Contributor
Hi @GuillaumeGomez, this is great, I haven't tested it yet but there are some issues:
I'll test it as soon as I find some time and return to you if I find anymore issue. Your |
GuillaumeGomez
commented
Feb 24, 2018
MemberAuthor
Ok, writing a second PR which adds an |
shepmaster
commented
Mar 2, 2018
Member
Ping from triage, @QuietMisdreavus ! |
GuillaumeGomez
commented
Mar 3, 2018
MemberAuthor
I'll close this PR in favor of #48511. |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2018
…fix, r=QuietMisdreavus Add resource-suffix option for rustdoc Alternative version of rust-lang#48442. cc @onur r? @QuietMisdreavus
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2018
…fix, r=QuietMisdreavus Add resource-suffix option for rustdoc Alternative version of rust-lang#48442. cc @onur r? @QuietMisdreavus
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 7, 2018
…fix, r=QuietMisdreavus Add resource-suffix option for rustdoc Alternative version of rust-lang#48442. cc @onur r? @QuietMisdreavus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @QuietMisdreavus
cc @onur
I tested everything that came to my mind but I'm pretty sure I didn't think of a corner case where this feature could break. Any feedback/additional tests would be very appreciated. :)