Skip to content

[stable] 1.24.1 stable release - #48445

Merged
alexcrichton merged 6 commits into
rust-lang:stablefrom
Mark-Simulacrum:stable-next
Feb 27, 2018
Merged

[stable] 1.24.1 stable release#48445
alexcrichton merged 6 commits into
rust-lang:stablefrom
Mark-Simulacrum:stable-next

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Feb 22, 2018•
edited
Loading

Copy link
Copy Markdown
Member

The includes the following commits:

alexcrichtonand others added 2 commits February 22, 2018 14:34
@alexcrichton@Mark-Simulacrum
rustc: Don't use relative paths for extended errors
a5cf56d
These no longer work now that Cargo changes the cwd of rustc while it's running.
Instead use an absolute path that's set by rustbuild.
@nikomatsakis@Mark-Simulacrum
temporarily disablerust-lang#46833due torust-lang#48251
6a600f8
@rust-highfive

rust-highfive commented Feb 22, 2018

Copy link
Copy Markdown
Contributor

warningWarningwarning

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2018
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Feb 22, 2018
Closed
@alexcrichton

alexcrichton commented Feb 23, 2018

Copy link
Copy Markdown
Member

Since stable is so much more "expensive" to release for us I'd personally be far more comfortable only landing changes that are already released and tested in beta and stable, but would that delay this too much?

@Mark-Simulacrum

Mark-Simulacrum commented Feb 23, 2018

Copy link
Copy Markdown
MemberAuthor

Hm, I don't think so -- I'll go ahead and merge the relevant PRs that exist and try to put up PRs where they don't. We're currently targeting Monday for the release, though I have a feeling that will slip to Thursday while we wait for confirmation from stakeholders (after we've uploaded artifacts to dev-static).

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Feb 23, 2018
Closed
@Eh2406Eh2406 mentioned this pull request Feb 23, 2018
Closed
@Eh2406

Eh2406 commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

There is some discussion of asking for a 1.24.1 to give better error messages for the Cargo GitHub Win7 thing. I have no opinion just trying to connect the discussions.

@Mark-Simulacrum
Mark-Simulacrum requested review from alexcrichton and removed request for alexcrichtonFebruary 23, 2018 20:30
@alexcrichton

alexcrichton commented Feb 26, 2018

Copy link
Copy Markdown
Member

I've added a commit which includes rust-lang/cargo#5086 as well.

@matkladmatklad mentioned this pull request Feb 27, 2018
Closed
@Mark-Simulacrum

Mark-Simulacrum commented Feb 27, 2018

Copy link
Copy Markdown
MemberAuthor

Discussed with @alexcrichton, we're going to go ahead and merge this. We'll be discussing this further during the next core team meeting and deciding whether or not we will actually release 1.24.1 then.

@bors r=alexcrichton

@bors

bors commented Feb 27, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 9853d20 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@kennytm

kennytm commented Feb 27, 2018

Copy link
Copy Markdown
Member

@bors p=1000

@bors

bors commented Feb 27, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9853d20 with merge f81cfc31499534859f933aa1a68f58ad801a4d14...

@bors

bors commented Feb 27, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@Mark-Simulacrum

Mark-Simulacrum commented Feb 27, 2018

Copy link
Copy Markdown
MemberAuthor

@bors retry -- appveyor timeout

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@bors

bors commented Feb 27, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9853d20 with merge d3ae9a9...

bors added a commit that referenced this pull request Feb 27, 2018
@bors
Auto merge of#48445- Mark-Simulacrum:stable-next, r=alexcrichton
d3ae9a9
[stable] 1.24.1 stable release
The includes the following commits:
- 6a600f8: Fixes#48251, unwinding through FFI no longer aborts
- cuviper@b445a52: Fixes#48308, fixing the error index generator
- f8e00d0: Fixes#48318 by emitting UTF-16 output on MSVC targets.
- 2a0af8c448: Bumps the version number to 1.24.1.
- 93220f0f45: Release notes
- 6031718d8836f95bbfeddfaa63f1ee1d66e53f26: Cargo TLS warnings on Windows.
@bors

bors commented Feb 27, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@alexcrichton

alexcrichton commented Feb 27, 2018

Copy link
Copy Markdown
Member

All dist targets succeeded, merging manually

@alexcrichton
alexcrichton merged commit 9853d20 into rust-lang:stableFeb 27, 2018
@Mark-Simulacrum
Mark-Simulacrum deleted the stable-next branch February 28, 2018 19:17
@alexcrichtonalexcrichton mentioned this pull request Jul 24, 2018
Closed
yuriks added a commit to yuriks/reference that referenced this pull request Sep 25, 2020
@yuriks
Update guarantees of unwinding past an extern "C" function
7657115
The current docs say it will abort, however that behavior was actually reverted in rust-lang/rust#48445 and is not what currently happens in stable.
@yuriksyuriks mentioned this pull request Sep 25, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Mark-Simulacrum@rust-highfive@alexcrichton@Eh2406@bors@kennytm@aturon@nikomatsakis