Skip to content

Support parentheses in patterns under feature gate - #48500

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:parpat
Mar 2, 2018
Merged

Support parentheses in patterns under feature gate#48500
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:parpat

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Feb 24, 2018

Copy link
Copy Markdown
Contributor

This is a prerequisite for any other extensions to pattern syntax - | with multiple patterns, type ascription, ..PAT in slice patterns.

Closesrust-lang/rfcs#554

@rust-highfive

rust-highfive commented Feb 24, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2018
@petrochenkov

petrochenkov commented Feb 24, 2018

Copy link
Copy Markdown
ContributorAuthor

cc @rust-lang/lang
r? @nikomatsakis

@petrochenkov

petrochenkov commented Feb 24, 2018

Copy link
Copy Markdown
ContributorAuthor

Also related to #48501

@kennytmkennytm added the T-lang Relevant to the language team label Feb 24, 2018
@bors

bors commented Feb 25, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #48520) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2018
@petrochenkovpetrochenkov mentioned this pull request Feb 25, 2018
Open
@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2018
@nikomatsakis

nikomatsakis commented Feb 26, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Indeed, I see no reason not to permit () in patterns. Surprised we don't already. I guess we never needed it before.

@durkadurka mentioned this pull request Feb 27, 2018
Closed
8 tasks
@kennytmkennytm mentioned this pull request Feb 27, 2018
Merged
nikomatsakis
nikomatsakis approved these changes Feb 27, 2018
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nits addressed

Comment threadsrc/libsyntax/parse/parser.rs Outdated

@nikomatsakisnikomatsakisFeb 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd prefer a name like parse_pat_parenthesized_list. Also, a comment explaining this would be nice. Something like:

Parses a parenthesized list of patterns like (), (p), (p,), (p, q), or (p, q, ..). Returns a vector of the subpatterns that were parsed, along with (a) an option indicating the index of the .. element and (b) a boolean indicating whether a trailing comma was present. Trailing commas are significant because (p) and (p,) are different patterns.

@petrochenkov
Support parentheses in patterns under feature gate
c9aff92
Improve recovery for trailing comma after `..`
@petrochenkov

petrochenkov commented Feb 28, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented Feb 28, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit c9aff92 has been approved by nikomatsakis

@bors

bors commented Feb 28, 2018

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 200, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2018
@ManishearthManishearth mentioned this pull request Mar 1, 2018
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2018
@Manishearth
Rollup merge ofrust-lang#48500- petrochenkov:parpat, r=nikomatsakis
38f4d55
Support parentheses in patterns under feature gate
This is a prerequisite for any other extensions to pattern syntax - `|` with multiple patterns, type ascription, `..PAT` in slice patterns.
Closesrust-lang/rfcs#554
@ManishearthManishearth mentioned this pull request Mar 2, 2018
Merged
@bors
bors merged commit c9aff92 into rust-lang:masterMar 2, 2018
@kennytmkennytm mentioned this pull request Mar 2, 2018
Merged
@petrochenkovpetrochenkov mentioned this pull request Mar 2, 2018
Closed
@kennytmkennytm mentioned this pull request Apr 15, 2018
Closed
This was referenced May 26, 2018
Closed
Closed
@kestredkestred mentioned this pull request Nov 11, 2018
Closed
@petrochenkov
petrochenkov deleted the parpat branch June 5, 2019 16:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-langRelevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@rust-highfive@bors@nikomatsakis@kennytm