Skip to content

impl Clone for ::std_unicode::char::{ToLowercase, ToUppercase} - #48629

Merged
bors merged 1 commit into
rust-lang:masterfrom
strake:char
Mar 3, 2018
Merged

impl Clone for ::std_unicode::char::{ToLowercase, ToUppercase}#48629
bors merged 1 commit into
rust-lang:masterfrom
strake:char

Conversation

@strake

@strakestrake commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2018
@alexcrichtonalexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 1, 2018
@alexcrichton

alexcrichton commented Mar 1, 2018

Copy link
Copy Markdown
Member

@bors: r+

Thanks!

cc @rust-lang/libs

@bors

bors commented Mar 1, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 5ac4f62 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2018
@ManishearthManishearth mentioned this pull request Mar 2, 2018
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 2, 2018
@Manishearth
Rollup merge ofrust-lang#48629- strake:char, r=alexcrichton
a000d41
Fixesrust-lang#47311.
r? @nrc
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 3, 2018
@Manishearth
Rollup merge ofrust-lang#48629- strake:char, r=alexcrichton
d7b5985
Fixesrust-lang#47311.
r? @nrc
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 3, 2018
@Manishearth
Rollup merge ofrust-lang#48629- strake:char, r=alexcrichton
75ccd63
impl Clone for ::std_unicode::char::{ToLowercase, ToUppercase}
@ManishearthManishearth mentioned this pull request Mar 3, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 3, 2018
@kennytm
Rollup merge ofrust-lang#48629- strake:char, r=alexcrichton
ad1cc0c
impl Clone for ::std_unicode::char::{ToLowercase, ToUppercase}
@kennytmkennytm mentioned this pull request Mar 3, 2018
Merged
bors added a commit that referenced this pull request Mar 3, 2018
@bors
Auto merge of#48694- kennytm:rollup, r=kennytm
e026b59
Rollup of 8 pull requests
- Successful merges: #48283, #48466, #48569, #48629, #48637, #48680, #48513, #48664
- Failed merges:
@bors
bors merged commit 5ac4f62 into rust-lang:masterMar 3, 2018
@strake
strake deleted the char branch March 26, 2018 18:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@strake@rust-highfive@alexcrichton@bors