Move ascii::escape_default to libcore by 1011X · Pull Request #48735 · rust-lang/rust

1011X · 2018-03-04T19:44:08Z

As requested in #46409, the ascii::escape_default method has been added to the core library. All I did was copy over the std::ascii module file, remove the (redundant) AsciiExt trait, and change some of the documentation to match. None of the tests were changed.

I wasn't sure how to handle the annotations. For EscapeDefault and escape_default(), I changed them to #[unstable(feature = "core_ascii", issue = "46409")]. Is that alright? Or should I leave them as they were?

rust-highfive · 2018-03-04T19:44:19Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

1011X · 2018-03-05T03:31:32Z

I changed the annotations to stable with the version as 1.26.0, which is the current nightly version.

Mark-Simulacrum · 2018-03-05T04:06:08Z

r? @BurntSushi

BurntSushi · 2018-03-05T11:50:14Z

I don't know what our decision procedure is for moving things into core. @alexcrichton?

alexcrichton · 2018-03-05T17:02:16Z

Ah I think we'd go through the normal FCP process for this as it would be an insta-stable definition in libcore. @1011X I'd sort of expect though for the original definition to be deleted from somewhere, does that still need to happen?

Also currently libcore for various technical reasons the tests go in src/libcore/tests unlike other libraries where it's indeed inline with the source itself.

1011X · 2018-03-05T20:22:17Z

Oh right, I'll delete them from std and re-export the ones in core, and move the tests as well. My bad, I'm still figuring out how std and core are organized.

Since the tests are the same, should I delete the ones in std::ascii?

alexcrichton · 2018-03-05T20:40:58Z

Yeah no need to duplicate the tests as well, thanks!

bors · 2018-03-06T18:09:40Z

☔ The latest upstream changes (presumably #48768) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2018-03-08T15:55:05Z

@1011X oh I think there's also a modification necessary in src/libcore/tests/mod.rs to actually bring the tests in as well?

Otherwise this looks good to me, thanks!

@rfcbot fcp merge

rfcbot · 2018-03-08T15:55:06Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2018-03-08T17:22:02Z

🔔 This is now entering its final comment period, as per the review above. 🔔

1011X · 2018-03-09T04:08:30Z

@alexcrichton Got it! Thanks for the help :)

alexcrichton · 2018-03-09T19:06:21Z

Looks like CI may have some errors?

alexcrichton · 2018-03-12T17:47:43Z

@bors: r+

bors · 2018-03-12T17:47:44Z

📌 Commit 1a16271 has been approved by alexcrichton

bors · 2018-03-13T19:50:20Z

⌛ Testing commit 1a16271 with merge c290857...

Move ascii::escape_default to libcore As requested in #46409, the `ascii::escape_default` method has been added to the core library. All I did was copy over the `std::ascii` module file, remove the (redundant) `AsciiExt` trait, and change some of the documentation to match. None of the tests were changed. I wasn't sure how to handle the annotations. For `EscapeDefault` and `escape_default()`, I changed them to `#[unstable(feature = "core_ascii", issue = "46409")]`. Is that alright? Or should I leave them as they were?

bors · 2018-03-13T22:39:16Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c290857 to master...

Correct a few stability attributes * `const_indexing` language feature was stabilized in 1.26.0 by #46882 * `Display` impls for `PanicInfo` and `Location` were stabilized in 1.26.0 by #47687 * `TrustedLen` is still unstable so its impls should be as well even though `RangeInclusive` was stabilized by #47813 * `!Send` and `!Sync` for `Args` and `ArgsOs` were stabilized in 1.26.0 by #48005 * `EscapeDefault` has been stable since 1.0.0 so should continue to show that even though it was moved to core in #48735 This could be backported to beta like #49612

1011X added 4 commits March 4, 2018 13:33

Added ascii module to core
4e4c1b5

Merge branch 'master' of github.com:1011X/rust
df283db

Declare ascii module in libcore/lib.rs
16076d4

Fix unintended rename and a doc example
bebc340

rust-highfive assigned Mark-Simulacrum Mar 4, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2018

1011X added 2 commits March 4, 2018 18:36

Fix doc example
1a4aa1e

Fix doc example, and change fn annotation to stable
9bfc062

rust-highfive assigned BurntSushi and unassigned Mark-Simulacrum Mar 5, 2018

1011X added 3 commits March 5, 2018 16:39

Move tests, re-export items from core::ascii
1b3d1fc

Copy license into libcore/tests/ascii.rs
a39b62d

Remove unnecessary imports
aa1ded9

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018

Merge branch 'master' ofhttps://github.com/rust-lang/rust
06bad6a

kennytm added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 6, 2018

FusedIterator will be stabilized
a0c6262

rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 8, 2018

alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 8, 2018

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 8, 2018

1011X added 2 commits March 8, 2018 22:55

declare ascii test module in core
679e410

Merge branch 'master' of github.com:1011X/rust
39c3a37

clarfonthey mentioned this pull request Mar 9, 2018
Allow "infinity" and ignore case when parsing floats. #48886
Closed

1011X added 2 commits March 12, 2018 01:04

include AsciiExt in tests
8654738

added ascii_ctypes feature to libcore tests module
1a16271

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2018

bors merged commit 1a16271 into rust-lang:masterMar 13, 2018

Phlosioneer mentioned this pull request Mar 20, 2018
Move ascii::escape_default to core for no_std support #46409
Closed

ollie27 mentioned this pull request Apr 5, 2018
Correct a few stability attributes #49673
Merged

Uh oh!

Uh oh!

Conversation

1011X commented Mar 4, 2018

Uh oh!

rust-highfive commented Mar 4, 2018

Uh oh!

1011X commented Mar 5, 2018

Uh oh!

Mark-Simulacrum commented Mar 5, 2018

Uh oh!

BurntSushi commented Mar 5, 2018

Uh oh!

alexcrichton commented Mar 5, 2018

Uh oh!

1011X commented Mar 5, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Mar 5, 2018

Uh oh!

bors commented Mar 6, 2018

Uh oh!

alexcrichton commented Mar 8, 2018

Uh oh!

rfcbot commented Mar 8, 2018• edited by aturon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Mar 8, 2018

Uh oh!

1011X commented Mar 9, 2018

Uh oh!

alexcrichton commented Mar 9, 2018

Uh oh!

alexcrichton commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

bors commented Mar 13, 2018

Uh oh!

bors commented Mar 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

1011X commented Mar 5, 2018•
edited
Loading

rfcbot commented Mar 8, 2018•
edited by aturon
Loading