Skip to content

Stabilize option_ref_mut_cloned - #48787

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
mbrubeck:cloned
Mar 8, 2018
Merged

Stabilize option_ref_mut_cloned#48787
alexcrichton merged 1 commit into
rust-lang:masterfrom
mbrubeck:cloned

Conversation

@mbrubeck

Copy link
Copy Markdown
Contributor

Closes#43738.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2018
@kennytmkennytm added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 6, 2018
@joshtriplett

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 6, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 0539613 has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018
@Aaron1011

Copy link
Copy Markdown
Contributor

The doc comment for that function still contains the #[feature] attribute, under the Examples heading:

 /// #![feature(option_ref_mut_cloned)]
/// let mut x = 12;

Since the feature is being stabilized, I believe that should be removed.

@mbrubeck

Copy link
Copy Markdown
ContributorAuthor

The doc comment for that function still contains the #[feature] attribute

Fixed, thanks. r? @joshtriplett

@joshtriplett

Copy link
Copy Markdown
Member

Good catch, thank you!

@joshtriplett

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 6, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit d04362f has been approved by joshtriplett

@CentrilCentril added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 7, 2018
@alexcrichton

Copy link
Copy Markdown
Member

@bors: rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018
bors added a commit that referenced this pull request Mar 7, 2018
Rollup of 9 pull requests
- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018
bors added a commit that referenced this pull request Mar 7, 2018
Rollup of 9 pull requests
- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
bors added a commit that referenced this pull request Mar 7, 2018
Rollup of 9 pull requests
- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
@alexcrichton
alexcrichton merged commit d04362f into rust-lang:masterMar 8, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@mbrubeck@rust-highfive@joshtriplett@bors@Aaron1011@alexcrichton@kennytm@Centril