Skip to content

travis: Upgrade OSX builders - #48799

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:more-osx-cores
Mar 11, 2018
Merged

travis: Upgrade OSX builders#48799
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:more-osx-cores

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Mar 6, 2018

Copy link
Copy Markdown
Member

This upgrades the OSX builders to the xcode9.3-moar image which has 3 cores as
opposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!

@alexcrichton

alexcrichton commented Mar 6, 2018

Copy link
Copy Markdown
MemberAuthor

r? @kennytm

@Mark-Simulacrum

Mark-Simulacrum commented Mar 7, 2018

Copy link
Copy Markdown
Member

Hm, I'm somewhat hesitant because of the debuginfo breakage but I also think this is somewhat more important -- breakage looks relatively minor. @bors r+

@bors

bors commented Mar 7, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit a3ac9f1 has been approved by Mark-Simulacrum

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 7, 2018
@alexcrichton

alexcrichton commented Mar 7, 2018

Copy link
Copy Markdown
MemberAuthor

@bors: r-

Looks like reproducible builds on 64-bit OSX regresses

However 32-bit builds get 40 minutes faster, so that's nice!

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 7, 2018
@alexcrichton

alexcrichton commented Mar 7, 2018

Copy link
Copy Markdown
MemberAuthor

@bors: r=Mark-Simulacrum

@bors

bors commented Mar 7, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 51321c7 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2018
alexcrichton
alexcrichton commented Mar 7, 2018
View reviewed changes
Comment threadsrc/test/run-make/long-linker-command-lines/Makefile Outdated

@alexcrichtonalexcrichtonMar 7, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this test took forever without optimizations. It still takes a long time with them, but it's at least a little better

alexcrichton
alexcrichton commented Mar 7, 2018
View reviewed changes
Comment threadsrc/test/run-make/reproducible-build/Makefile Outdated

@alexcrichtonalexcrichtonMar 7, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote this test to be a little more resilient against system linkers. We're sort of always assuming the system linker is deterministic, and if it's not then there's not much we can do about that...

@alexcrichton
travis: Upgrade OSX builders
55a2fdf
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as
opposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!
@alexcrichton

alexcrichton commented Mar 7, 2018

Copy link
Copy Markdown
MemberAuthor

@bors: r=Mark-Simulacrum

confirmed fixed now!

@bors

bors commented Mar 7, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 55a2fdf has been approved by Mark-Simulacrum

@alexcrichton

alexcrichton commented Mar 9, 2018

Copy link
Copy Markdown
MemberAuthor

@bors: rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 9, 2018
@Mark-Simulacrum
Rollup merge ofrust-lang#48799- alexcrichton:more-osx-cores, r=Mark…
77be280
…-Simulacrum
travis: Upgrade OSX builders
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as
opposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Mar 9, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 10, 2018
@Mark-Simulacrum
Rollup merge ofrust-lang#48799- alexcrichton:more-osx-cores, r=Mark…
4f4069d
…-Simulacrum
travis: Upgrade OSX builders
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as
opposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Mar 10, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 10, 2018
@kennytm
Rollup merge ofrust-lang#48799- alexcrichton:more-osx-cores, r=Mark…
0a0c28f
…-Simulacrum
travis: Upgrade OSX builders
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as
opposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!
@kennytmkennytm mentioned this pull request Mar 10, 2018
Closed
@kennytm

kennytm commented Mar 11, 2018

Copy link
Copy Markdown
Member

@bors rollup- p=1

@bors

bors commented Mar 11, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 55a2fdf with merge e5acb0c...

bors added a commit that referenced this pull request Mar 11, 2018
@bors
Auto merge of#48799- alexcrichton:more-osx-cores, r=Mark-Simulacrum
e5acb0c
travis: Upgrade OSX builders
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as
opposed to the 2 that our builders currently have. Should help make those OSX
builds a bit speedier!
@bors

bors commented Mar 11, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing e5acb0c to master...

@bors
bors merged commit 55a2fdf into rust-lang:masterMar 11, 2018
@borsbors mentioned this pull request Mar 11, 2018
Merged
@kennytmkennytm mentioned this pull request Mar 11, 2018
Merged
@alexcrichton
alexcrichton deleted the more-osx-cores branch March 19, 2018 17:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytmkennytm

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcrichton@Mark-Simulacrum@bors@kennytm