Uh oh!
There was an error while loading. Please reload this page.
Stabilize attributes on generic parameters - #48851
Merged
Merged
Conversation
rust-highfive
commented
Mar 8, 2018
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Mar 8, 2018
ContributorAuthor
bors
commented
Mar 9, 2018
Collaborator
☔ The latest upstream changes (presumably #48860) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
commented
Mar 14, 2018
Contributor
Blocked on FCP in #48848 |
emilyalbini
commented
Mar 26, 2018
Member
The FCP in #48848 ended. Can you review this @nikomatsakis? Also @petrochenkov, there are some merge conflicts you should fix. |
nikomatsakis
approved these changes
Apr 4, 2018
nikomatsakis
commented
Apr 4, 2018
Contributor
r=me post rebase |
petrochenkov
commented
Apr 4, 2018
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Apr 4, 2018
Collaborator
📌 Commit 1a2a234 has been approved by |
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 5, 2018
…akis Stabilize attributes on generic parameters Closesrust-lang#48848
bors
commented
Apr 5, 2018
Collaborator
bors added a commit
that referenced
this pull request
Apr 5, 2018
Stabilize attributes on generic parameters Closes#48848
kennytm
reviewed
Apr 5, 2018
| // allow `'_` placeholder lifetimes | ||
| (accepted, underscore_lifetimes, "1.26.0", Some(44524), None), | ||
| // Allows attributes on lifetime/type formal parameters in generics (RFC 1327) | ||
| (accepted, generic_param_attrs, "1.26.0", Some(48848), None), |
bors
commented
Apr 5, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#48848