Skip to content

Modify part of line! documentation. - #48856

Merged
bors merged 1 commit into
rust-lang:masterfrom
Songbird0:improve_line_macro_documentation
Mar 9, 2018
Merged

Modify part of line! documentation.#48856
bors merged 1 commit into
rust-lang:masterfrom
Songbird0:improve_line_macro_documentation

Conversation

@Songbird0

@Songbird0Songbird0 commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

In accordance with #46997, I've replaced:

The returned line is not the invocation of the line! macro itself [...]

By

The returned line is not necessarily the line of the line! invocation itself [...]

@Songbird0
Modify part of line! documentation.
2d7472f
In accordance with rust-lang#46997, I've replaced:
> The returned line is not the invocation of the line! macro itself [...]
By
> The returned line is *not necessarily* the line of the `line!` invocation itself [...]
@rust-highfive

rust-highfive commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2018
@joshtriplett

joshtriplett commented Mar 8, 2018

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 8, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 2d7472f has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2018
@joshtriplettjoshtriplett mentioned this pull request Mar 8, 2018
Merged
@joshtriplett

joshtriplett commented Mar 8, 2018

Copy link
Copy Markdown
Member

Thanks for your contribution! I love seeing this kind of clarification.

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 9, 2018
@Manishearth
Rollup merge ofrust-lang#48856- Songbird0:improve_line_macro_docume…
5ab4855
…ntation, r=joshtriplett
Modify part of `line!` documentation.
In accordance with rust-lang#46997, I've replaced:
> The returned line is not the invocation of the line! macro itself [...]
By
> The returned line is *not necessarily* the line of the `line!` invocation itself [...]
@ManishearthManishearth mentioned this pull request Mar 9, 2018
Merged
bors added a commit that referenced this pull request Mar 9, 2018
@bors
Auto merge of#48860- Manishearth:rollup, r=Manishearth
2079a08
Rollup of 5 pull requests
- Successful merges: #48527, #48588, #48801, #48856, #48857
- Failed merges:
@bors
bors merged commit 2d7472f into rust-lang:masterMar 9, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Songbird0@rust-highfive@joshtriplett@bors