Speed up SVH computation by using Fingerprint::combine()

[hrvolapeter]

Fix#47297

r? @michaelwoerister

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[michaelwoerister]

to_vec() will copy the whole vector. However, since we take self by value here, we can safely modify it in place. If you declare self mutable, then you should be able to do the following:

self.hir_body_nodes.sort_unstable_by(|&(ref d1, _),&(ref d2, _)| d1.cmp(d2));let node_hashes = self.hir_body_nodes.iter()
...

[hrvolapeter]

thank you for review, I was not sure if it won't brake anything. However, modifying hir_body_nodes itself will make the code a lot faster.

[michaelwoerister]

Thanks for the PR, @retep007!

[hrvolapeter]

fixed

r? @michaelwoerister

[michaelwoerister]

Thanks, @retep007!

@bors r+

[bors]

📌 Commit 2f2e173 has been approved by michaelwoerister