[beta] Update RLS by nrc · Pull Request #49156 · rust-lang/rust

nrc · 2018-03-19T01:13:04Z

Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable.

We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.

Mark-Simulacrum · 2018-03-19T03:12:30Z

We roll out beta releases on each PR merge anyway. I'm somewhat hesitant to do this the week before the release -- is there a chance we know of the specific commit which will reduce flakiness in RLS, so that we could backport just it?

Otherwise thought this seems fine if it gets past bors.

nrc · 2018-03-19T03:58:55Z

is there a chance we know of the specific commit which will reduce flakiness in RLS

No, there are a whole bunch of commits which help here, and I'm not sure it is possible (or desirable) to cherry-pick those without the other stuff.

Mark-Simulacrum · 2018-03-19T12:48:56Z

Okay. @bors r+ p=3

bors · 2018-03-19T12:48:57Z

📌 Commit 08a9e27 has been approved by Mark-Simulacrum

bors · 2018-03-19T13:31:51Z

⌛ Testing commit 08a9e27 with merge ef3368a...

@alexcrichton

Update RLS r? @alexcrichton Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable. We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.

Mark-Simulacrum · 2018-03-19T18:41:09Z

@bors retry

Though bors apparently doesn't know it yet, this did fail Appveyor.

bors · 2018-03-19T19:59:31Z

⌛ Testing commit 08a9e27 with merge b82c4701e2f2518ee04de7c8a35356b185a4d048...

bors · 2018-03-19T23:00:41Z

💔 Test failed - status-travis

kennytm · 2018-03-19T23:05:56Z

@bors retry

3 hour timeout on asmjs, check i686-pc-windows-msvc, check i686-pc-windows-gnu, the usual suspects.

bors · 2018-03-20T03:24:53Z

⌛ Testing commit 08a9e27 with merge b16a56de2e85bc84d2d115697a3ab0a21c6f2932...

bors · 2018-03-20T06:26:39Z

💔 Test failed - status-appveyor

kennytm · 2018-03-21T13:21:09Z

@bors retry

bors · 2018-03-21T16:32:28Z

⌛ Testing commit 08a9e27 with merge 70ad4bf146636a21f325abccf71da1c79520e50a...

bors · 2018-03-21T17:12:30Z

💔 Test failed - status-travis

kennytm · 2018-03-21T17:17:55Z

@bors retry treeclosed=30

Lots of network issue when connecting to the GCC FTP server. Figuring out solutions.

The former seems much more stable, in case the cache becomes invalidated.

alexcrichton · 2018-03-22T20:22:06Z

@bors: p=100

This is really cutting it close for a backport as this'll be release to stable basically in a few days, but if we gotta get it in we gotta get it in now.

Added in commits from #49246

alexcrichton · 2018-03-22T20:22:26Z

@bors: r+

bors · 2018-03-22T20:22:28Z

📌 Commit 07e4c9e has been approved by alexcrichton

bors · 2018-03-22T23:03:04Z

⌛ Testing commit 07e4c9e with merge 745ad86...

@alexcrichton

[beta] Update RLS r? @alexcrichton Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable. We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.

bors · 2018-03-23T01:44:07Z

💔 Test failed - status-travis

alexcrichton · 2018-03-23T01:58:38Z

@bors: retry

/Users/travis/.rvm/gems/ruby-2.2.5/gems/aws-sdk-core-2.6.5/lib/aws-sdk-core/xml/doc_builder.rb:64:in `encode': dlopen(enc/trans/escape.so, 9): image not found - enc/trans/escape.so (LoadError)

wut?!

@kennytm I think we really need to stop using Travis deploy

bors · 2018-03-23T01:59:23Z

⌛ Testing commit 07e4c9e with merge 1104e76...

@alexcrichton

[beta] Update RLS r? @alexcrichton Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable. We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.

bors · 2018-03-23T05:42:56Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1104e76 to beta...

Update RLS
08a9e27

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 19, 2018

bors mentioned this pull request Mar 19, 2018
Improve lint for type alias bounds #48909
Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2018

kennytm changed the title ~~Update RLS~~[beta] Update RLSMar 19, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018

kennytm added 2 commits March 22, 2018 13:20

Download the GCC artifacts from the HTTP server instead of FTP server.
0983cf3
The former seems much more stable, in case the cache becomes invalidated.

Handle redirects correctly.
07e4c9e

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018

bors merged commit 07e4c9e into rust-lang:betaMar 23, 2018

Uh oh!

Uh oh!

Conversation

nrc commented Mar 19, 2018

Uh oh!

Mark-Simulacrum commented Mar 19, 2018

Uh oh!

nrc commented Mar 19, 2018

Uh oh!

Mark-Simulacrum commented Mar 19, 2018

Uh oh!

bors commented Mar 19, 2018

Uh oh!

bors commented Mar 19, 2018

Uh oh!

Mark-Simulacrum commented Mar 19, 2018

Uh oh!

bors commented Mar 19, 2018

Uh oh!

bors commented Mar 19, 2018

Uh oh!

kennytm commented Mar 19, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

kennytm commented Mar 21, 2018

Uh oh!

bors commented Mar 21, 2018

Uh oh!

bors commented Mar 21, 2018

Uh oh!

kennytm commented Mar 21, 2018

Uh oh!

alexcrichton commented Mar 22, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Mar 22, 2018

Uh oh!

bors commented Mar 22, 2018

Uh oh!

bors commented Mar 22, 2018

Uh oh!

bors commented Mar 23, 2018

Uh oh!

alexcrichton commented Mar 23, 2018

Uh oh!

bors commented Mar 23, 2018

Uh oh!

bors commented Mar 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexcrichton commented Mar 22, 2018•
edited
Loading